Merge "Cleanup outdated TODOs" into rvc-dev (6d410d81) · Commits · e / os / android_frameworks_base

core/java/com/android/internal/app/ChooserActivity.java

+0 −4

Original line number	Diff line number	Diff line
		@@ -793,7 +793,6 @@ public class ChooserActivity extends ResolverActivity implements
		private AppPredictor.Callback createAppPredictorCallback(
		ChooserListAdapter chooserListAdapter) {
		return resultList -> {
		//TODO(arangelov) Take care of edge case when callback called after swiping tabs
		if (isFinishing() \|\| isDestroyed()) {
		return;
		}
		@@ -802,8 +801,6 @@ public class ChooserActivity extends ResolverActivity implements
		}
		if (resultList.isEmpty()) {
		// APS may be disabled, so try querying targets ourselves.
		//TODO(arangelov) queryDirectShareTargets indirectly uses mIntents.
		// Investigate implications for work tab.
		queryDirectShareTargets(chooserListAdapter, true);
		return;
		}
		@@ -1976,7 +1973,6 @@ public class ChooserActivity extends ResolverActivity implements
		}
		}
		// Default to just querying ShortcutManager if AppPredictor not present.
		//TODO(arangelov) we're using mIntents here, investicate possible implications on work tab
		final IntentFilter filter = getTargetIntentFilter();
		if (filter == null) {
		return;

+0 −3

Original line number	Diff line number	Diff line
		@@ -159,9 +159,6 @@ public class ResolverActivity extends Activity implements
		protected static final String METRICS_CATEGORY_RESOLVER = "intent_resolver";
		protected static final String METRICS_CATEGORY_CHOOSER = "intent_chooser";

		/**
		* TODO(arangelov): Remove a couple of weeks after work/personal tabs are finalized.
		*/
		@VisibleForTesting
		public static boolean ENABLE_TABBED_VIEW = true;
		private static final String TAB_TAG_PERSONAL = "personal";

+0 −1

Original line number	Diff line number	Diff line
		@@ -423,7 +423,6 @@ public class ResolverListAdapter extends BaseAdapter {
		// We assume that at this point we've already filtered out the only intent for a different
		// targetUserId which we're going to use.
		private void addResolveInfo(DisplayResolveInfo dri) {
		// TODO(arangelov): Is that UserHandle.USER_CURRENT check okay?
		if (dri != null && dri.getResolveInfo() != null
		&& dri.getResolveInfo().targetUserId == UserHandle.USER_CURRENT) {
		if (shouldAddResolveInfo(dri)) {