Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d23a051 authored by Milo Sredkov's avatar Milo Sredkov
Browse files

Tweak the sizes of the smart reply buttons 

Tweak the sizes of the smart reply buttons to be more consistent with
the rest of the notification UI.

Note that the padding for two-line buttons needs to be different from
the padding for one-line buttons until b/78876518 is fixed.

Screenshot before: https://screenshot.googleplex.com/ePaB3YZfLEk.png
Screenshot after: https://screenshot.googleplex.com/vZmPq7AyYOB.png
Two line version: https://screenshot.googleplex.com/9o8PxMusDXV.png

Bug: 73605520
Test: In Notify post a Messaging notification with chices
Change-Id: I4ef16dc8fb2682f9ac1a74aecadf8b6b6799cfb3
parent e4d1cabe

packages/SystemUI/res/drawable/smart_reply_button_background.xml

+2 −2
Original line number Diff line number Diff line
@@ -21,9 +21,9 @@ 
    <item>

        <inset

            android:insetLeft="0dp"

            android:insetTop="7dp"

            android:insetTop="8dp"

            android:insetRight="0dp"

            android:insetBottom="5dp">

            android:insetBottom="8dp">

            <shape android:shape="rectangle">

                <corners android:radius="8dp" />

                <stroke android:width="1dp" android:color="@color/smart_reply_button_stroke" />

packages/SystemUI/res/layout/smart_reply_button.xml

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 
        android:paddingVertical="@dimen/smart_reply_button_padding_vertical"

        android:background="@drawable/smart_reply_button_background"

        android:gravity="center"

        android:fontFamily="sans-serif-medium"

        android:fontFamily="roboto-medium"

        android:textSize="@dimen/smart_reply_button_font_size"

        android:lineSpacingExtra="@dimen/smart_reply_button_line_spacing_extra"

        android:textColor="@color/smart_reply_button_text"

packages/SystemUI/res/values/dimens.xml

+6 −5
Original line number Diff line number Diff line
@@ -930,12 +930,13 @@ 
    <!-- Home button padding for sizing -->

    <dimen name="home_padding">16dp</dimen>



    <!-- Smart reply button -->

    <!-- Smart reply button. Total height 48dp, visible height 32dp. -->

    <dimen name="smart_reply_button_spacing">8dp</dimen>

    <dimen name="smart_reply_button_padding_vertical">10dp</dimen>

    <dimen name="smart_reply_button_padding_horizontal_single_line">16dp</dimen>

    <dimen name="smart_reply_button_padding_horizontal_double_line">16dp</dimen>

    <dimen name="smart_reply_button_min_height">32dp</dimen>

    <dimen name="smart_reply_button_padding_vertical">14dp</dimen>

    <!-- Note: The following two paddings need to be different until b/78876518 is fixed. -->

    <dimen name="smart_reply_button_padding_horizontal_single_line">20dp</dimen>

    <dimen name="smart_reply_button_padding_horizontal_double_line">19dp</dimen>

    <dimen name="smart_reply_button_min_height">48dp</dimen>

    <dimen name="smart_reply_button_font_size">14sp</dimen>

    <dimen name="smart_reply_button_line_spacing_extra">6sp</dimen> <!-- Total line height 20sp. -->