Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ce5b00f authored by Ryan Mitchell's avatar Ryan Mitchell
Browse files

Revert "Enforce a default policy on packages without <overlayable>" 

This reverts commit 48945224.

Reason for revert: <b/127835630>

Change-Id: I0bc90c26e5b7d6b4d94704a2a1f92bbc889c025c
parent 48945224

cmds/idmap2/libidmap2/Idmap.cpp

+3 −18
Original line number Diff line number Diff line
@@ -287,20 +287,11 @@ std::unique_ptr<const Idmap> Idmap::FromBinaryStream(std::istream& stream, 
bool CheckOverlayable(const LoadedPackage& target_package,

                      const utils::OverlayManifestInfo& overlay_info,

                      const PolicyBitmask& fulfilled_policies, const ResourceId& resid) {

  static constexpr const PolicyBitmask sDefaultPolicies =

      PolicyFlags::POLICY_SYSTEM_PARTITION | PolicyFlags::POLICY_VENDOR_PARTITION |

      PolicyFlags::POLICY_PRODUCT_PARTITION | PolicyFlags::POLICY_SIGNATURE;



  // If the resource does not have an overlayable definition, allow the resource to be overlaid if

  // the overlay is preinstalled or signed with the same signature as the target.

  if (!target_package.DefinesOverlayable()) {

    return (sDefaultPolicies & fulfilled_policies) != 0;

  }



  const OverlayableInfo* overlayable_info = target_package.GetOverlayableInfo(resid);

  if (overlayable_info == nullptr) {

    // Do not allow non-overlayable resources to be overlaid.

    return false;

    // If the resource does not have an overlayable definition, allow the resource to be overlaid.

    // Once overlayable enforcement is turned on, this check will return false.

    return !target_package.DefinesOverlayable();

  }



  if (overlay_info.target_name != overlayable_info->name) {
@@ -436,12 +427,6 @@ std::unique_ptr<const Idmap> Idmap::FromApkAssets( 
    matching_resources.Add(target_resid, overlay_resid);

  }



  if (matching_resources.Map().empty()) {

    out_error << "overlay \"" << overlay_apk_path << "\" does not successfully overlay any resource"

              << std::endl;

    return nullptr;

  }



  // encode idmap data

  std::unique_ptr<IdmapData> data(new IdmapData());

  const auto types_end = matching_resources.Map().cend();

cmds/idmap2/tests/IdmapTests.cpp

+156 −118
Original line number Diff line number Diff line
@@ -173,27 +173,20 @@ TEST(IdmapTests, GracefullyFailToCreateIdmapFromCorruptBinaryStream) { 
  ASSERT_THAT(idmap, IsNull());

}



void CreateIdmap(const StringPiece& target_apk_path, const StringPiece& overlay_apk_path,

                 const PolicyBitmask& fulfilled_policies, bool enforce_overlayable,

                 std::unique_ptr<const Idmap>* out_idmap) {

  std::unique_ptr<const ApkAssets> target_apk = ApkAssets::Load(target_apk_path.to_string());

TEST(IdmapTests, CreateIdmapFromApkAssets) {

  const std::string target_apk_path(GetTestDataPath() + "/target/target.apk");

  std::unique_ptr<const ApkAssets> target_apk = ApkAssets::Load(target_apk_path);

  ASSERT_THAT(target_apk, NotNull());



  std::unique_ptr<const ApkAssets> overlay_apk = ApkAssets::Load(overlay_apk_path.to_string());

  const std::string overlay_apk_path(GetTestDataPath() + "/overlay/overlay.apk");

  std::unique_ptr<const ApkAssets> overlay_apk = ApkAssets::Load(overlay_apk_path);

  ASSERT_THAT(overlay_apk, NotNull());



  std::stringstream error;

  *out_idmap =

      Idmap::FromApkAssets(target_apk_path.to_string(), *target_apk, overlay_apk_path.to_string(),

                           *overlay_apk, fulfilled_policies, enforce_overlayable, error);

}



TEST(IdmapTests, CreateIdmapFromApkAssets) {

  std::unique_ptr<const Idmap> idmap;

  std::string target_apk_path = GetTestDataPath() + "/target/target.apk";

  std::string overlay_apk_path = GetTestDataPath() + "/overlay/overlay.apk";

  CreateIdmap(target_apk_path, overlay_apk_path, PolicyFlags::POLICY_PUBLIC,

              /* enforce_overlayable */ true, &idmap);

  std::unique_ptr<const Idmap> idmap =

      Idmap::FromApkAssets(target_apk_path, *target_apk, overlay_apk_path, *overlay_apk,

                           PolicyFlags::POLICY_PUBLIC, /* enforce_overlayable */ true, error);

  ASSERT_THAT(idmap, NotNull());



  ASSERT_THAT(idmap->GetHeader(), NotNull());

  ASSERT_EQ(idmap->GetHeader()->GetMagic(), 0x504d4449U);
@@ -233,12 +226,19 @@ TEST(IdmapTests, CreateIdmapFromApkAssets) { 


// Overlays should abide by all overlayable restrictions if enforcement of overlayable is enabled.

TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsPolicySystemPublic) {

  std::unique_ptr<const Idmap> idmap;

  std::string target_apk_path = GetTestDataPath() + "/target/target.apk";

  std::string overlay_apk_path = GetTestDataPath() + "/system-overlay/system-overlay.apk";

  CreateIdmap(target_apk_path, overlay_apk_path,

  const std::string target_apk_path(GetTestDataPath() + "/target/target.apk");

  std::unique_ptr<const ApkAssets> target_apk = ApkAssets::Load(target_apk_path);

  ASSERT_THAT(target_apk, NotNull());



  const std::string overlay_apk_path(GetTestDataPath() + "/system-overlay/system-overlay.apk");

  std::unique_ptr<const ApkAssets> overlay_apk = ApkAssets::Load(overlay_apk_path);

  ASSERT_THAT(overlay_apk, NotNull());



  std::stringstream error;

  std::unique_ptr<const Idmap> idmap =

      Idmap::FromApkAssets(target_apk_path, *target_apk, overlay_apk_path, *overlay_apk,

                           PolicyFlags::POLICY_SYSTEM_PARTITION | PolicyFlags::POLICY_PUBLIC,

              /* enforce_overlayable */ true, &idmap);

                           /* enforce_overlayable */ true, error);

  ASSERT_THAT(idmap, NotNull());



  const std::vector<std::unique_ptr<const IdmapData>>& dataBlocks = idmap->GetData();
@@ -263,12 +263,21 @@ TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsPolicySystemPublic) { 
}



TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsPolicySignature) {

  std::unique_ptr<const Idmap> idmap;

  std::string target_apk_path = GetTestDataPath() + "/target/target.apk";

  std::string overlay_apk_path = GetTestDataPath() + "/signature-overlay/signature-overlay.apk";

  CreateIdmap(target_apk_path, overlay_apk_path,

              PolicyFlags::POLICY_PUBLIC | PolicyFlags::POLICY_SIGNATURE,

              /* enforce_overlayable */ true, &idmap);

  const std::string target_apk_path(GetTestDataPath() + "/target/target.apk");

  std::unique_ptr<const ApkAssets> target_apk = ApkAssets::Load(target_apk_path);

  ASSERT_THAT(target_apk, NotNull());



  const std::string overlay_apk_path(GetTestDataPath() +

                                     "/signature-overlay/signature-overlay.apk");

  std::unique_ptr<const ApkAssets> overlay_apk = ApkAssets::Load(overlay_apk_path);

  ASSERT_THAT(overlay_apk, NotNull());



  uint32_t policy_flags = PolicyFlags::POLICY_PUBLIC | PolicyFlags::POLICY_SIGNATURE;



  std::stringstream error;

  std::unique_ptr<const Idmap> idmap =

      Idmap::FromApkAssets(target_apk_path, *target_apk, overlay_apk_path, *overlay_apk,

                           policy_flags, /* enforce_overlayable */ true, error);

  ASSERT_THAT(idmap, NotNull());



  const std::vector<std::unique_ptr<const IdmapData>>& dataBlocks = idmap->GetData();
@@ -289,15 +298,52 @@ TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsPolicySignature) { 
  ASSERT_EQ(types[0]->GetEntry(0), 0x0000U);  // string/policy_signature

}



TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsPolicySignatureNotFulfilled) {

  const std::string target_apk_path(GetTestDataPath() + "/target/target.apk");

  std::unique_ptr<const ApkAssets> target_apk = ApkAssets::Load(target_apk_path);

  ASSERT_THAT(target_apk, NotNull());



  const std::string overlay_apk_path(GetTestDataPath() +

                                     "/signature-overlay/signature-overlay.apk");

  std::unique_ptr<const ApkAssets> overlay_apk = ApkAssets::Load(overlay_apk_path);

  ASSERT_THAT(overlay_apk, NotNull());



  uint32_t policy_flags = PolicyFlags::POLICY_PUBLIC;



  std::stringstream error;

  std::unique_ptr<const Idmap> idmap =

      Idmap::FromApkAssets(target_apk_path, *target_apk, overlay_apk_path, *overlay_apk,

                           policy_flags, /* enforce_overlayable */ true, error);

  ASSERT_THAT(idmap, NotNull());



  const std::vector<std::unique_ptr<const IdmapData>>& dataBlocks = idmap->GetData();

  ASSERT_EQ(dataBlocks.size(), 1U);



  const std::unique_ptr<const IdmapData>& data = dataBlocks[0];



  ASSERT_EQ(data->GetHeader()->GetTargetPackageId(), 0x7fU);

  ASSERT_EQ(data->GetHeader()->GetTypeCount(), 0U);



  const std::vector<std::unique_ptr<const IdmapData::TypeEntry>>& types = data->GetTypeEntries();

  ASSERT_EQ(types.size(), 0U);  // can't overlay, so contains nothing

}



// Overlays should abide by all overlayable restrictions if enforcement of overlayable is enabled.

TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsPolicySystemPublicInvalid) {

  std::unique_ptr<const Idmap> idmap;

  std::string target_apk_path = GetTestDataPath() + "/target/target.apk";

  std::string overlay_apk_path =

      GetTestDataPath() + "/system-overlay-invalid/system-overlay-invalid.apk";

  CreateIdmap(target_apk_path, overlay_apk_path,

  const std::string target_apk_path(GetTestDataPath() + "/target/target.apk");

  std::unique_ptr<const ApkAssets> target_apk = ApkAssets::Load(target_apk_path);

  ASSERT_THAT(target_apk, NotNull());



  const std::string overlay_apk_path(GetTestDataPath() +

                                     "/system-overlay-invalid/system-overlay-invalid.apk");

  std::unique_ptr<const ApkAssets> overlay_apk = ApkAssets::Load(overlay_apk_path);

  ASSERT_THAT(overlay_apk, NotNull());



  std::stringstream error;

  std::unique_ptr<const Idmap> idmap =

      Idmap::FromApkAssets(target_apk_path, *target_apk, overlay_apk_path, *overlay_apk,

                           PolicyFlags::POLICY_SYSTEM_PARTITION | PolicyFlags::POLICY_PUBLIC,

              /* enforce_overlayable */ true, &idmap);

                           /* enforce_overlayable */ true, error);

  ASSERT_THAT(idmap, NotNull());



  const std::vector<std::unique_ptr<const IdmapData>>& dataBlocks = idmap->GetData();
@@ -323,13 +369,20 @@ TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsPolicySystemPublicInvalid) { 


// Overlays should ignore all overlayable restrictions if enforcement of overlayable is disabled.

TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsPolicySystemPublicInvalidIgnoreOverlayable) {

  std::unique_ptr<const Idmap> idmap;

  std::string target_apk_path = GetTestDataPath() + "/target/target.apk";

  std::string overlay_apk_path =

      GetTestDataPath() + "/system-overlay-invalid/system-overlay-invalid.apk";

  CreateIdmap(target_apk_path, overlay_apk_path,

  const std::string target_apk_path(GetTestDataPath() + "/target/target.apk");

  std::unique_ptr<const ApkAssets> target_apk = ApkAssets::Load(target_apk_path);

  ASSERT_THAT(target_apk, NotNull());



  const std::string overlay_apk_path(GetTestDataPath() +

                                     "/system-overlay-invalid/system-overlay-invalid.apk");

  std::unique_ptr<const ApkAssets> overlay_apk = ApkAssets::Load(overlay_apk_path);

  ASSERT_THAT(overlay_apk, NotNull());



  std::stringstream error;

  std::unique_ptr<const Idmap> idmap =

      Idmap::FromApkAssets(target_apk_path, *target_apk, overlay_apk_path, *overlay_apk,

                           PolicyFlags::POLICY_SYSTEM_PARTITION | PolicyFlags::POLICY_PUBLIC,

              /* enforce_overlayable */ false, &idmap);

                           /* enforce_overlayable */ false, error);

  ASSERT_THAT(idmap, NotNull());



  const std::vector<std::unique_ptr<const IdmapData>>& dataBlocks = idmap->GetData();
@@ -356,62 +409,24 @@ TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsPolicySystemPublicInvalidIgn 
  ASSERT_EQ(types[0]->GetEntry(6), 0x0006U);  // string/policy_system_vendor

}



// Overlays that do not specify a target <overlayable> can overlay resources defined as overlayable.

TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsNoDefinedOverlayableAndNoTargetName) {

  std::unique_ptr<const Idmap> idmap;

  std::string target_apk_path = GetTestDataPath() + "/target/target-no-overlayable.apk";

  std::string overlay_apk_path = GetTestDataPath() + "/overlay/overlay-no-name.apk";

  CreateIdmap(target_apk_path, overlay_apk_path, PolicyFlags::POLICY_PUBLIC,

              /* enforce_overlayable */ false, &idmap);

  ASSERT_THAT(idmap, NotNull());



  const std::vector<std::unique_ptr<const IdmapData>>& dataBlocks = idmap->GetData();

  ASSERT_EQ(dataBlocks.size(), 1U);



  const std::unique_ptr<const IdmapData>& data = dataBlocks[0];



  ASSERT_EQ(data->GetHeader()->GetTargetPackageId(), 0x7fU);

  ASSERT_EQ(data->GetHeader()->GetTypeCount(), 2U);



  const std::vector<std::unique_ptr<const IdmapData::TypeEntry>>& types = data->GetTypeEntries();

  ASSERT_EQ(types.size(), 2U);



  ASSERT_EQ(types[0]->GetTargetTypeId(), 0x01U);

  ASSERT_EQ(types[0]->GetOverlayTypeId(), 0x01U);

  ASSERT_EQ(types[0]->GetEntryCount(), 1U);

  ASSERT_EQ(types[0]->GetEntryOffset(), 0U);

  ASSERT_EQ(types[0]->GetEntry(0), 0x0000U);  // string/int1



  ASSERT_EQ(types[1]->GetTargetTypeId(), 0x02U);

  ASSERT_EQ(types[1]->GetOverlayTypeId(), 0x02U);

  ASSERT_EQ(types[1]->GetEntryCount(), 4U);

  ASSERT_EQ(types[1]->GetEntryOffset(), 10U);

  ASSERT_EQ(types[1]->GetEntry(0), 0x0000U);   // string/str1

  ASSERT_EQ(types[1]->GetEntry(1), kNoEntry);  // string/str2

  ASSERT_EQ(types[1]->GetEntry(2), 0x0001U);   // string/str3

  ASSERT_EQ(types[1]->GetEntry(3), 0x0002U);   // string/str4

}

// The resources of APKs that do not include an overlayable declaration should not restrict what

// resources can be overlaid.

TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsNoDefinedOverlayable) {

  const std::string target_apk_path(GetTestDataPath() + "/target/target-no-overlayable.apk");

  std::unique_ptr<const ApkAssets> target_apk = ApkAssets::Load(target_apk_path);

  ASSERT_THAT(target_apk, NotNull());



// Overlays that are not pre-installed and are not signed with the same signature as the target

// cannot overlay packages that have not defined overlayable resources.

TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsDefaultPoliciesPublicFail) {

  std::unique_ptr<const Idmap> idmap;

  std::string target_apk_path = GetTestDataPath() + "/target/target-no-overlayable.apk";

  std::string overlay_apk_path = GetTestDataPath() + "/overlay/overlay-no-name.apk";

  CreateIdmap(target_apk_path, overlay_apk_path, PolicyFlags::POLICY_PUBLIC,

              /* enforce_overlayable */ true, &idmap);

  ASSERT_THAT(idmap, IsNull());

}

  const std::string overlay_apk_path(GetTestDataPath() +

                                     "/system-overlay-invalid/system-overlay-invalid.apk");

  std::unique_ptr<const ApkAssets> overlay_apk = ApkAssets::Load(overlay_apk_path);

  ASSERT_THAT(overlay_apk, NotNull());



// Overlays that are pre-installed or are signed with the same signature as the target can overlay

// packages that have not defined overlayable resources.

TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsDefaultPolicies) {

  std::unique_ptr<const Idmap> idmap;

  std::string target_apk_path = GetTestDataPath() + "/target/target-no-overlayable.apk";

  std::string overlay_apk_path =

      GetTestDataPath() + "/system-overlay-invalid/system-overlay-invalid.apk";

  std::stringstream error;

  std::unique_ptr<const Idmap> idmap =

      Idmap::FromApkAssets(target_apk_path, *target_apk, overlay_apk_path, *overlay_apk,

                           PolicyFlags::POLICY_PUBLIC, /* enforce_overlayable */ true, error);

  ASSERT_THAT(idmap, NotNull());



  auto CheckEntries = [&]() -> void {

  const std::vector<std::unique_ptr<const IdmapData>>& dataBlocks = idmap->GetData();

  ASSERT_EQ(dataBlocks.size(), 1U);
@@ -434,27 +449,50 @@ TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsDefaultPolicies) { 
  ASSERT_EQ(types[0]->GetEntry(4), 0x0004U);  // string/string/policy_signature

  ASSERT_EQ(types[0]->GetEntry(5), 0x0005U);  // string/policy_system

  ASSERT_EQ(types[0]->GetEntry(6), 0x0006U);  // string/policy_system_vendor

  };

}



  CreateIdmap(target_apk_path, overlay_apk_path, PolicyFlags::POLICY_SIGNATURE,

              /* enforce_overlayable */ true, &idmap);

  ASSERT_THAT(idmap, NotNull());

  CheckEntries();

// The resources of APKs that do not include an overlayable declaration should not restrict what

// resources can be overlaid.

TEST(IdmapOverlayableTests, CreateIdmapFromApkAssetsNoDefinedOverlayableAndNoTargetName) {

  const std::string target_apk_path(GetTestDataPath() + "/target/target-no-overlayable.apk");

  std::unique_ptr<const ApkAssets> target_apk = ApkAssets::Load(target_apk_path);

  ASSERT_THAT(target_apk, NotNull());



  CreateIdmap(target_apk_path, overlay_apk_path, PolicyFlags::POLICY_PRODUCT_PARTITION,

              /* enforce_overlayable */ true, &idmap);

  ASSERT_THAT(idmap, NotNull());

  CheckEntries();

  const std::string overlay_apk_path(GetTestDataPath() + "/overlay/overlay-no-name.apk");

  std::unique_ptr<const ApkAssets> overlay_apk = ApkAssets::Load(overlay_apk_path);

  ASSERT_THAT(overlay_apk, NotNull());



  CreateIdmap(target_apk_path, overlay_apk_path, PolicyFlags::POLICY_SYSTEM_PARTITION,

              /* enforce_overlayable */ true, &idmap);

  std::stringstream error;

  std::unique_ptr<const Idmap> idmap =

      Idmap::FromApkAssets(target_apk_path, *target_apk, overlay_apk_path, *overlay_apk,

                           PolicyFlags::POLICY_PUBLIC, /* enforce_overlayable */ true, error);

  ASSERT_THAT(idmap, NotNull());

  CheckEntries();



  CreateIdmap(target_apk_path, overlay_apk_path, PolicyFlags::POLICY_VENDOR_PARTITION,

              /* enforce_overlayable */ true, &idmap);

  ASSERT_THAT(idmap, NotNull());

  CheckEntries();

  const std::vector<std::unique_ptr<const IdmapData>>& dataBlocks = idmap->GetData();

  ASSERT_EQ(dataBlocks.size(), 1U);



  const std::unique_ptr<const IdmapData>& data = dataBlocks[0];



  ASSERT_EQ(data->GetHeader()->GetTargetPackageId(), 0x7fU);

  ASSERT_EQ(data->GetHeader()->GetTypeCount(), 2U);



  const std::vector<std::unique_ptr<const IdmapData::TypeEntry>>& types = data->GetTypeEntries();

  ASSERT_EQ(types.size(), 2U);



  ASSERT_EQ(types[0]->GetTargetTypeId(), 0x01U);

  ASSERT_EQ(types[0]->GetOverlayTypeId(), 0x01U);

  ASSERT_EQ(types[0]->GetEntryCount(), 1U);

  ASSERT_EQ(types[0]->GetEntryOffset(), 0U);

  ASSERT_EQ(types[0]->GetEntry(0), 0x0000U);



  ASSERT_EQ(types[1]->GetTargetTypeId(), 0x02U);

  ASSERT_EQ(types[1]->GetOverlayTypeId(), 0x02U);

  ASSERT_EQ(types[1]->GetEntryCount(), 4U);

  ASSERT_EQ(types[1]->GetEntryOffset(), 10U);

  ASSERT_EQ(types[1]->GetEntry(0), 0x0000U);

  ASSERT_EQ(types[1]->GetEntry(1), kNoEntry);

  ASSERT_EQ(types[1]->GetEntry(2), 0x0001U);

  ASSERT_EQ(types[1]->GetEntry(3), 0x0002U);

}



TEST(IdmapTests, FailToCreateIdmapFromApkAssetsIfPathTooLong) {

cmds/idmap2/tests/data/overlay/build

+1 −1
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ 
# See the License for the specific language governing permissions and

# limitations under the License.



FRAMEWORK_RES_APK=${ANDROID_BUILD_TOP}/prebuilts/sdk/current/public/android.jar

FRAMEWORK_RES_APK="${ANDROID_BUILD_TOP}/out/target/common/obj/APPS/framework-res_intermediates/package-export.apk"



aapt2 compile --dir res -o compiled.flata