Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6c89d1e3 authored by Matt Pietal's avatar Matt Pietal
Browse files

Controls a11y - Fix title repetition, min height 

There is no need for a content description on the associated icon, as
the title is sufficient.

Bug: 153288023
Bug: 153291530
Test: talkback
Change-Id: I8617151cbbbb24f437e93a7c106997ef355206b6
parent bcc707d4

packages/SystemUI/res/layout/controls_spinner_item.xml

+1 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ 
        android:layout_gravity="center"

        android:layout_width="@dimen/controls_header_app_icon_size"

        android:layout_height="@dimen/controls_header_app_icon_size"

        android:contentDescription="@null"

        android:layout_marginEnd="10dp" />



    <TextView

packages/SystemUI/res/layout/controls_with_favorites.xml

+2 −0
Original line number Diff line number Diff line
@@ -34,6 +34,7 @@ 
        android:orientation="horizontal"

        android:layout_width="0dp"

        android:layout_weight="1"

        android:minHeight="48dp"

        android:layout_height="wrap_content"

        android:layout_gravity="center"

        android:gravity="center">
@@ -43,6 +44,7 @@ 
          android:layout_gravity="center"

          android:layout_width="@dimen/controls_header_app_icon_size"

          android:layout_height="@dimen/controls_header_app_icon_size"

          android:contentDescription="@null"

          android:layout_marginEnd="10dp" />



      <TextView

packages/SystemUI/src/com/android/systemui/controls/ui/ControlsUiControllerImpl.kt

+0 −2
Original line number Diff line number Diff line
@@ -361,7 +361,6 @@ class ControlsUiControllerImpl @Inject constructor ( 
                .setTint(context.resources.getColor(R.color.control_spinner_dropdown, null))

        }

        parent.requireViewById<ImageView>(R.id.app_icon).apply {

            setContentDescription(selectionItem.getTitle())

            setImageDrawable(selectionItem.icon)

        }
@@ -585,7 +584,6 @@ private class ItemAdapter( 
            setText(item.getTitle())

        }

        view.requireViewById<ImageView>(R.id.app_icon).apply {

            setContentDescription(item.appName)

            setImageDrawable(item.icon)

        }

        return view