Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6af0e228 authored by Chih-hung Hsieh's avatar Chih-hung Hsieh Committed by Gerrit Code Review
Browse files

Merge "Fix/suppress incident* google-explicit-constructor warnings"

parents 63790135 7a88a938
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ class TextParserBase {
public:
    String8 name;

    TextParserBase(String8 name) : name(name) {};
    explicit TextParserBase(String8 name) : name(name) {};
    virtual ~TextParserBase() {};

    virtual status_t Parse(const int in, const int out) const = 0;
+2 −2
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ double toDouble(const std::string& s);
class Reader
{
public:
    Reader(const int fd);
    explicit Reader(const int fd);
    ~Reader();

    bool readLine(std::string* line);
@@ -162,7 +162,7 @@ private:
class Message
{
public:
    Message(Table* table);
    explicit Message(Table* table);
    ~Message();

    // Reconstructs the typical proto message by adding its message fields.
+1 −1
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ private:
// ================================================================================
class IncidentService : public BnIncidentManager {
public:
    IncidentService(const sp<Looper>& handlerLooper);
    explicit IncidentService(const sp<Looper>& handlerLooper);
    virtual ~IncidentService();

    virtual Status reportIncident(const IncidentReportArgs& args);
+1 −1
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ public:
    static PrivacySpec new_spec(int dest);

private:
    PrivacySpec(uint8_t dest) : dest(dest) {}
    explicit PrivacySpec(uint8_t dest) : dest(dest) {}
};

}  // namespace incidentd
+1 −1
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ public:
    ReportRequestSet batch;

    Reporter();                       // PROD must use this constructor.
    Reporter(const char* directory);  // For testing purpose only.
    explicit Reporter(const char* directory);  // For testing purpose only.
    virtual ~Reporter();

    // Run the report as described in the batch and args parameters.
Loading