Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a938aae authored Mar 13, 2019 by Yunfan Chen

Get flaky test out of pre-submit and move non-flaky test into it.

The two tests in TaskStackChangedListenerTest is no longer flaky and the
flaky annotation was removed before. But the presubmit annotation is
missing. Promote them into presubmit.

The test testProcessTwoItems_OneAfterAnother caused 29 flakes during the
past 7 days. Move it out of pre-submit first.

Bug: 123654474
Bug: 128526085
Test: atest PersisterQueueTests
Test: atest TaskStackChangedListenerTest
Change-Id: Iffe89b6b441cd1ecb67e7d77220dd5d282cd57cd

parent 9699ac5e

services/tests/wmtests/src/com/android/server/wm/PersisterQueueTests.java

+2 −0

Original line number	Diff line number	Diff line
		@@ -28,6 +28,7 @@ import static org.junit.Assert.assertTrue;
		import android.os.SystemClock;
		import android.platform.test.annotations.Presubmit;

		import androidx.test.filters.FlakyTest;
		import androidx.test.filters.MediumTest;

		import org.junit.After;
		@@ -157,6 +158,7 @@ public class PersisterQueueTests implements PersisterQueue.Listener {
		}

		@Test
		@FlakyTest(bugId = 128526085)
		public void testProcessTwoItems_OneAfterAnother() throws Exception {
		// First item
		mLatch = new CountDownLatch(1);

services/tests/wmtests/src/com/android/server/wm/TaskStackChangedListenerTest.java

+2 −0

Original line number	Diff line number	Diff line
		@@ -100,6 +100,7 @@ public class TaskStackChangedListenerTest {
		}

		@Test
		@Presubmit
		public void testTaskDescriptionChanged() throws Exception {
		final Object[] params = new Object[2];
		final CountDownLatch latch = new CountDownLatch(1);
		@@ -132,6 +133,7 @@ public class TaskStackChangedListenerTest {
		}

		@Test
		@Presubmit
		public void testActivityRequestedOrientationChanged() throws Exception {
		final int[] params = new int[2];
		final CountDownLatch latch = new CountDownLatch(1);