Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6a26e93c authored by Felipe Leme's avatar Felipe Leme
Browse files

Re-add callback to onCancel() when screen is touched outside Save UI. 

That callback was accidentally removed because it should not trigger the
negative listener, but the right approach was to pass a null listener.

Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Bug: 66235266
Fixes: 66944844

Change-Id: I5b71d3d03335d952e3b47078d1373f9783366437
parent 8e5e30c5

services/autofill/java/com/android/server/autofill/ui/SaveUi.java

+4 −0
Original line number Diff line number Diff line
@@ -271,6 +271,10 @@ final class SaveUi { 
        mDialog = new Dialog(context, R.style.Theme_DeviceDefault_Light_Panel);

        mDialog.setContentView(view);



        // Dialog can be dismissed when touched outside, but the negative listener should not be

        // notified (hence the null argument).

        mDialog.setOnDismissListener((d) -> mListener.onCancel(null));



        final Window window = mDialog.getWindow();

        window.setType(WindowManager.LayoutParams.TYPE_APPLICATION_OVERLAY);

        window.addFlags(WindowManager.LayoutParams.FLAG_NOT_FOCUSABLE