Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 69e6349a authored by Arne Coucheron's avatar Arne Coucheron Committed by Łukasz Patron
Browse files

SystemUI: Allow disabling BrightlineFalsingManager with config flag 

The anti-falsing implementation does not work well on some
devices, and regularly prevents easy swipe to unlock or to
pattern / pin on the keyguard lockscreen, requiring multiple
attempts until accepted.

Use existing config_lockscreenAntiFalsingClassifierEnabled flag
to allow it to be disabled. By default it's enabled.

Change-Id: Ib91fc2386f70f56aad68a0f7ad2e3445fbb42d79
parent 24283fe1

packages/SystemUI/src/com/android/systemui/classifier/FalsingManagerProxy.java

+5 −1
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ package com.android.systemui.classifier; 
import static com.android.internal.config.sysui.SystemUiDeviceConfigFlags.BRIGHTLINE_FALSING_MANAGER_ENABLED;



import android.content.Context;

import android.content.res.Resources;

import android.hardware.SensorManager;

import android.net.Uri;

import android.provider.DeviceConfig;
@@ -30,6 +31,7 @@ import androidx.annotation.NonNull; 
import com.android.internal.annotations.VisibleForTesting;

import com.android.keyguard.KeyguardUpdateMonitor;

import com.android.systemui.Dumpable;

import com.android.systemui.R;

import com.android.systemui.classifier.brightline.BrightLineFalsingManager;

import com.android.systemui.classifier.brightline.FalsingDataProvider;

import com.android.systemui.dagger.qualifiers.Main;
@@ -129,8 +131,10 @@ public class FalsingManagerProxy implements FalsingManager, Dumpable { 
     * Chooses the FalsingManager implementation.

     */

    private void setupFalsingManager(Context context) {

        Resources res = context.getResources();

        boolean brightlineEnabled = mDeviceConfig.getBoolean(

                DeviceConfig.NAMESPACE_SYSTEMUI, BRIGHTLINE_FALSING_MANAGER_ENABLED, true);

                DeviceConfig.NAMESPACE_SYSTEMUI, BRIGHTLINE_FALSING_MANAGER_ENABLED,

                res.getBoolean(R.bool.config_lockscreenAntiFalsingClassifierEnabled));

        if (brightlineEnabled == mBrightlineEnabled && mInternalFalsingManager != null) {

            return;

        }