Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 692f4561 authored by Ioana Alexandru's avatar Ioana Alexandru
Browse files

Update height and radius of smart actions 

Make the visible height of the smart reply/smart action buttons 32dp
instead of 36dp to match the animated ones
(animated_action_button_background). The real height of the tap target
is still 48dp though.

Also increase the radius so that the two-line action is also fully
rounded.

(I added a missing copyright to the animated action bg too, since I just
noticed it)

Fix: 427476371
Bug: 378660052
Test: manual & screenshot tests
Flag: android.app.notifications_redesign_templates
Change-Id: Icbfad4b055cd526039ad87c0b9c9d1d667d030d6
parent 4ceb4847

packages/SystemUI/res/drawable/animated_action_button_background.xml

+16 −0
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>



<!--

  ~ Copyright (C) 2025 The Android Open Source Project

  ~

  ~ Licensed under the Apache License, Version 2.0 (the "License");

  ~ you may not use this file except in compliance with the License.

  ~ You may obtain a copy of the License at

  ~

  ~      http://www.apache.org/licenses/LICENSE-2.0

  ~

  ~ Unless required by applicable law or agreed to in writing, software

  ~ distributed under the License is distributed on an "AS IS" BASIS,

  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

  ~ See the License for the specific language governing permissions and

  ~ limitations under the License

  -->



<ripple xmlns:android="http://schemas.android.com/apk/res/android"

    xmlns:androidprv="http://schemas.android.com/apk/prv/res/android"

    android:color="@color/notification_ripple_untinted_color">

packages/SystemUI/res/drawable/notification_2025_smart_reply_button_background.xml

+5 −3
Original line number Diff line number Diff line
@@ -18,12 +18,14 @@ 


<ripple xmlns:android="http://schemas.android.com/apk/res/android"

        android:color="@color/notification_ripple_untinted_color">

    <!-- Insets are chosen so that, in a container of height 48 (for the tap target), the chip

      has a height of 32dp. -->

    <item>

        <inset

            android:insetLeft="0dp"

            android:insetTop="6dp"

            android:insetTop="8dp"

            android:insetRight="0dp"

            android:insetBottom="6dp">

            android:insetBottom="8dp">

            <shape android:shape="rectangle">

                <corners android:radius="@dimen/notification_2025_smart_reply_button_corner_radius" />

                <stroke android:width="@dimen/smart_reply_button_stroke_width"

packages/SystemUI/res/values/dimens.xml

+1 −1
Original line number Diff line number Diff line
@@ -1194,7 +1194,7 @@ 
    <dimen name="smart_action_button_icon_size">18dp</dimen>

    <dimen name="smart_action_button_icon_padding">8dp</dimen>

    <dimen name="smart_action_button_outline_stroke_width">2dp</dimen>

    <dimen name="notification_2025_smart_reply_button_corner_radius">18dp</dimen>

    <dimen name="notification_2025_smart_reply_button_corner_radius">24dp</dimen>

    <dimen name="notification_2025_smart_reply_button_min_height">48dp</dimen>



    <!-- Animated Action params. -->