Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6867be45 authored by Hai Zhang's avatar Hai Zhang
Browse files

Call AbstractRemoteService.finishRequest() on PendingRequest timeout. 

Otherwise the request will never be removed from
AbstractRemoteService.mUnfinishedRequests. This is in line with the
BasePendingRequest.finish() implementation.

Test: presubmit
Change-Id: I38385d0c73b8bf34483af82d0b5282300fcacd1f
parent 9c57ba20

core/java/com/android/internal/infra/AbstractRemoteService.java

+1 −0
Original line number Diff line number Diff line
@@ -610,6 +610,7 @@ public abstract class AbstractRemoteService<S extends AbstractRemoteService<S, I 
                if (remoteService != null) {

                    // TODO(b/117779333): we should probably ignore it if service is destroyed.

                    Slog.w(mTag, "timed out after " + service.getRemoteRequestMillis() + " ms");

                    remoteService.finishRequest(this);

                    onTimeout(remoteService);

                } else {

                    Slog.w(mTag, "timed out (no service)");