Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 68613694 authored by Dieter Hsu's avatar Dieter Hsu
Browse files

Fix active permission touch target too small 

- Set buttons non-clickable to not consume events
- Add a11y contentDescription for active permissions buttons

Bug: 78198386
Test: manually receive messenger video call and verify touch targets
Test: manually record screen and verify with talkback/keyboard
Change-Id: I1b53cd1d7a88e44bd6e188b1055c8572c9d5731d
parent a1aafd77

core/res/res/layout/notification_template_header.xml

+6 −1
Original line number Original line Diff line number Diff line
@@ -126,7 +126,6 @@ 
        android:visibility="gone"

        android:visibility="gone"

        android:contentDescription="@string/notification_work_profile_content_description"

        android:contentDescription="@string/notification_work_profile_content_description"

        />

        />



    <LinearLayout

    <LinearLayout

        android:id="@+id/app_ops"

        android:id="@+id/app_ops"

        android:layout_height="match_parent"

        android:layout_height="match_parent"
@@ -140,6 +139,8 @@ 
            android:src="@drawable/ic_camera"

            android:src="@drawable/ic_camera"

            android:background="?android:selectableItemBackgroundBorderless"

            android:background="?android:selectableItemBackgroundBorderless"

            android:visibility="gone"

            android:visibility="gone"

            android:clickable="false"

            android:contentDescription="@string/notification_appops_camera_active"

            />

            />

        <ImageButton

        <ImageButton

            android:id="@+id/mic"

            android:id="@+id/mic"
@@ -149,6 +150,8 @@ 
            android:background="?android:selectableItemBackgroundBorderless"

            android:background="?android:selectableItemBackgroundBorderless"

            android:layout_marginStart="4dp"

            android:layout_marginStart="4dp"

            android:visibility="gone"

            android:visibility="gone"

            android:clickable="false"

            android:contentDescription="@string/notification_appops_microphone_active"

            />

            />

        <ImageButton

        <ImageButton

            android:id="@+id/overlay"

            android:id="@+id/overlay"
@@ -158,6 +161,8 @@ 
            android:background="?android:selectableItemBackgroundBorderless"

            android:background="?android:selectableItemBackgroundBorderless"

            android:layout_marginStart="4dp"

            android:layout_marginStart="4dp"

            android:visibility="gone"

            android:visibility="gone"

            android:clickable="false"

            android:contentDescription="@string/notification_appops_overlay_active"

            />

            />

    </LinearLayout>

    </LinearLayout>

</NotificationHeaderView>

</NotificationHeaderView>

core/res/res/values/strings.xml

+8 −0
Original line number Original line Diff line number Diff line
@@ -4969,6 +4969,14 @@ 
    <!-- Application name displayed in notifications [CHAR LIMIT=60] -->

    <!-- Application name displayed in notifications [CHAR LIMIT=60] -->

    <string name="notification_app_name_settings">Settings</string>

    <string name="notification_app_name_settings">Settings</string>





    <!-- Active Permission - accessibility support -->

    <!-- Content description of the camera icon in the notification. [CHAR LIMIT=NONE] -->

    <string name="notification_appops_camera_active">Camera</string>

    <!-- Content description of the mic icon in the notification. [CHAR LIMIT=NONE] -->

    <string name="notification_appops_microphone_active">Microphone</string>

    <!-- Content description of the overlay icon in the notification. [CHAR LIMIT=NONE] -->

    <string name="notification_appops_overlay_active">displaying over other apps on your screen</string>



    <!-- Strings for car -->

    <!-- Strings for car -->

    <!-- String displayed when loading a user in the car [CHAR LIMIT=30] -->

    <!-- String displayed when loading a user in the car [CHAR LIMIT=30] -->

    <string name="car_loading_profile">Loading</string>

    <string name="car_loading_profile">Loading</string>