Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 677999af authored by Lorenzo Colitti's avatar Lorenzo Colitti
Browse files

Add test coverage for NetworkSpecifiers. 

Tests various combinations of empty / non-empty NetworkSpecifiers
and changing specifiers on the fly.

Test: ConnectivityServiceTest passes
Bug: 27533960
Bug: 36053921
Change-Id: Ibd6b4efc861dc51689e46f3882ba859223411bf0
Merged-In: Ia7d36096f0e3f0b203d1d838043c03fcd1cea829
Merged-In: Ia71b72cc10dba6bac7c8fbe1ab3c5f40bc5506ff
parent 9d2f03ec

tests/net/java/com/android/server/ConnectivityServiceTest.java

+65 −0
Original line number Diff line number Diff line
@@ -319,6 +319,11 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
            mNetworkAgent.sendNetworkCapabilities(mNetworkCapabilities);

        }



        public void setNetworkSpecifier(String specifier) {

            mNetworkCapabilities.setNetworkSpecifier(specifier);

            mNetworkAgent.sendNetworkCapabilities(mNetworkCapabilities);

        }



        public void connectWithoutInternet() {

            mNetworkInfo.setDetailedState(DetailedState.CONNECTED, null, null);

            mNetworkAgent.sendNetworkInfo(mNetworkInfo);
@@ -1819,6 +1824,66 @@ public class ConnectivityServiceTest extends AndroidTestCase { 
        captivePortalCallback.assertNoCallback();

    }



    private NetworkRequest.Builder newWifiRequestBuilder() {

        return new NetworkRequest.Builder().addTransportType(TRANSPORT_WIFI);

    }



    @SmallTest

    public void testNetworkSpecifier() {

        NetworkRequest.Builder b = new NetworkRequest.Builder().addTransportType(TRANSPORT_WIFI);

        NetworkRequest rEmpty1 = newWifiRequestBuilder().build();

        NetworkRequest rEmpty2 = newWifiRequestBuilder().setNetworkSpecifier(null).build();

        NetworkRequest rEmpty3 = newWifiRequestBuilder().setNetworkSpecifier("").build();

        NetworkRequest rFoo = newWifiRequestBuilder().setNetworkSpecifier("foo").build();

        NetworkRequest rBar = newWifiRequestBuilder().setNetworkSpecifier("bar").build();



        TestNetworkCallback cEmpty1 = new TestNetworkCallback();

        TestNetworkCallback cEmpty2 = new TestNetworkCallback();

        TestNetworkCallback cEmpty3 = new TestNetworkCallback();

        TestNetworkCallback cFoo = new TestNetworkCallback();

        TestNetworkCallback cBar = new TestNetworkCallback();

        TestNetworkCallback[] emptyCallbacks = new TestNetworkCallback[] {

                cEmpty1, cEmpty2, cEmpty3 };



        mCm.registerNetworkCallback(rEmpty1, cEmpty1);

        mCm.registerNetworkCallback(rEmpty2, cEmpty2);

        mCm.registerNetworkCallback(rEmpty3, cEmpty3);

        mCm.registerNetworkCallback(rFoo, cFoo);

        mCm.registerNetworkCallback(rBar, cBar);



        mWiFiNetworkAgent = new MockNetworkAgent(TRANSPORT_WIFI);

        mWiFiNetworkAgent.connect(false);

        cEmpty1.expectAvailableCallbacks(mWiFiNetworkAgent);

        cEmpty2.expectAvailableCallbacks(mWiFiNetworkAgent);

        cEmpty3.expectAvailableCallbacks(mWiFiNetworkAgent);

        assertNoCallbacks(cFoo, cBar);



        mWiFiNetworkAgent.setNetworkSpecifier("foo");

        cFoo.expectAvailableCallbacks(mWiFiNetworkAgent);

        for (TestNetworkCallback c: emptyCallbacks) {

            c.expectCallback(CallbackState.NETWORK_CAPABILITIES, mWiFiNetworkAgent);

        }

        cFoo.expectCallback(CallbackState.NETWORK_CAPABILITIES, mWiFiNetworkAgent);

        cFoo.assertNoCallback();



        mWiFiNetworkAgent.setNetworkSpecifier("bar");

        cFoo.expectCallback(CallbackState.LOST, mWiFiNetworkAgent);

        cBar.expectAvailableCallbacks(mWiFiNetworkAgent);

        for (TestNetworkCallback c: emptyCallbacks) {

            c.expectCallback(CallbackState.NETWORK_CAPABILITIES, mWiFiNetworkAgent);

        }

        cBar.expectCallback(CallbackState.NETWORK_CAPABILITIES, mWiFiNetworkAgent);

        cBar.assertNoCallback();



        mWiFiNetworkAgent.setNetworkSpecifier(null);

        cBar.expectCallback(CallbackState.LOST, mWiFiNetworkAgent);

        for (TestNetworkCallback c: emptyCallbacks) {

            c.expectCallback(CallbackState.NETWORK_CAPABILITIES, mWiFiNetworkAgent);

        }



        assertNoCallbacks(cEmpty1, cEmpty2, cEmpty3, cFoo, cBar);

    }



    @SmallTest

    public void testInvalidNetworkSpecifier() {

        boolean execptionCalled = true;