Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 67623cf5 authored by Alex Johnston's avatar Alex Johnston
Browse files

setAutoTimeRequired disabled on managed profile 

* A security exception should be thrown when
  setAutoTimeRequired is called on a managed profile
* Update javadoc

Bug: 156620695
Test: atest com.android.server.devicepolicy.DevicePolicyManagerTest
      atest com.android.cts.devicepolicy.MixedDeviceOwnerTest#testSetAutoTimeRequired
      atest com.android.cts.devicepolicy.MixedProfileOwnerTest#testSetAutoTimeRequired
      atest com.android.cts.devicepolicy.MixedManagedProfileOwnerTest#testSetAutoTimeRequired
Change-Id: Ifb53c218947f62aa446aa607d3f4eee354586395
parent 78a66d6c

core/java/android/app/admin/DevicePolicyManager.java

+3 −1
Original line number Diff line number Diff line
@@ -6031,10 +6031,12 @@ public class DevicePolicyManager { 
     * this API to enforce auto time will result in

     * {@link UserManager#DISALLOW_CONFIG_DATE_TIME} being set, while calling this API to lift

     * the requirement will result in {@link UserManager#DISALLOW_CONFIG_DATE_TIME} being cleared.

     * From Android 11, this API can also no longer be called on a managed profile.

     *

     * @param admin Which {@link DeviceAdminReceiver} this request is associated with.

     * @param required Whether auto time is set required or not.

     * @throws SecurityException if {@code admin} is not a device owner.

     * @throws SecurityException if {@code admin} is not a device owner, not a profile owner or

     * if this API is called on a managed profile.

     * @deprecated From {@link android.os.Build.VERSION_CODES#R}. Use {@link #setAutoTimeEnabled}

     * to turn auto time on or off and use {@link UserManager#DISALLOW_CONFIG_DATE_TIME}

     * to prevent the user from changing this setting.

services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java

+3 −0
Original line number Diff line number Diff line
@@ -7968,6 +7968,9 @@ public class DevicePolicyManagerService extends BaseIDevicePolicyManager { 
        final int userHandle = UserHandle.getCallingUserId();

        boolean requireAutoTimeChanged = false;

        synchronized (getLockObject()) {

            if (isManagedProfile(userHandle)) {

                throw new SecurityException("Managed profile cannot set auto time required");

            }

            ActiveAdmin admin = getActiveAdminForCallerLocked(who,

                    DeviceAdminInfo.USES_POLICY_PROFILE_OWNER);

            if (admin.requireAutoTime != required) {