Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 670abea2 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Fix a typo in an error message in InputMethodManagerService 

This it a follow up CL to my previous CL [1], which introduced
EditorInfo#targetInputMethodUser.

There is a typo in Slog.e() message from
InputMethodManagerService#startInputOrWindowGainedFocusInternal() when
cross-user StartInput is requested without without
INTERACT_ACROSS_USERS_FULL permission.  This CL addresses the typo.

There should be no user-visible behavior change.

 [1]: Ia7ea944438d69669ccdf9111b34ba400e786a602
      0f5eade4

Bug: 120744418
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Change-Id: I09022bb225fb2e37ebf73218aedef9ab2503c53e
parent 6ab2e4a9

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+1 −1
Original line number Diff line number Diff line
@@ -2781,7 +2781,7 @@ public class InputMethodManagerService extends IInputMethodManager.Stub 
        if (attribute != null && attribute.targetInputMethodUser != null

                && attribute.targetInputMethodUser.getIdentifier() != callingUserId) {

            mContext.enforceCallingPermission(Manifest.permission.INTERACT_ACROSS_USERS_FULL,

                    "Using EditorInfo.user requires INTERACT_ACROSS_USERS_FULL.");

                    "Using EditorInfo.targetInputMethodUser requires INTERACT_ACROSS_USERS_FULL.");

            userId = attribute.targetInputMethodUser.getIdentifier();

            if (!mUserManagerInternal.isUserRunning(userId)) {

                // There is a chance that we hit here because of race condition.  Let's just return