Commit 668a339e authored Dec 03, 2024 by Ludovic Barman

LocationFudger: Bug fix in test.

This test should have the flag enabled, as the method name suggests.
The test was passing despite the wrong value of the flag because the tests checks that `getCoarseningLevel` wasn't called, which is trivially true if the flag is off.
The tests still passes when the flag is on.

This change has no impact on production code, only on tests.

Tests:
- atest FrameworksMockingServicesTests:LocationFudgerTest

Test: manual atest on Pixel 7 pro (see above)

Bug: 382014485

Flag: TEST_ONLY

Change-Id: Ia040d30b0e01aff5b60d5ba54b83d51bf1ddeebb

parent e761adc7

services/tests/mockingservicestests/src/com/android/server/location/fudger/LocationFudgerTest.java

+2 −2

Original line number	Diff line number	Diff line
		@@ -188,8 +188,8 @@ public class LocationFudgerTest {
		}

		@Test
		public void testDensityBasedCoarsening_ifFeatureIsEnabledButNotDefault_cacheIsNotUsed() {
		mSetFlagsRule.disableFlags(Flags.FLAG_DENSITY_BASED_COARSE_LOCATIONS);
		public void testDensityBasedCoarsening_ifFeatureIsEnabledButNoDefaultValue_cacheIsNotUsed() {
		mSetFlagsRule.enableFlags(Flags.FLAG_DENSITY_BASED_COARSE_LOCATIONS);
		LocationFudgerCache cache = mock(LocationFudgerCache.class);
		doReturn(false).when(cache).hasDefaultValue();