StatusBarMobileView: Properly init MobileGroup visibility (65c4b4cd) · Commits · e / os / android_frameworks_base

* We need to do it so that MobileGroup view visibility is initialized properly, otherwise it gets shown if you disable one of SIM cards and restart SystemUI, change visibility of any status bar icon, toggle airplane mode on and off or simply reboot your device (assuming the device is using real QCOM qti-telephony-common implementation). * By the way setVisibility() is smart enough to not do any 'hard work' when the flags are unchanged so we shouldn't see any perf regressions or anything like this. * Fixes: - https://gitlab.com/LineageOS/issues/android/issues/294 - https://gitlab.com/LineageOS/issues/android/issues/437 Change-Id: I7f620836a53b90426fd75d8c1e8b0f6bad6688dd

packages/SystemUI/src/com/android/systemui/statusbar/StatusBarMobileView.java

+3 −5

Original line number	Diff line number	Diff line
		@@ -145,7 +145,7 @@ public class StatusBarMobileView extends FrameLayout implements DarkReceiver,

		private void initViewState() {
		setContentDescription(mState.contentDescription);
		if (!mState.visible) {
		if (!mState.visible \|\| !mState.provisioned) {
		mMobileGroup.setVisibility(View.GONE);
		} else {
		mMobileGroup.setVisibility(View.VISIBLE);
		@@ -169,10 +169,8 @@ public class StatusBarMobileView extends FrameLayout implements DarkReceiver,

		private void updateState(MobileIconState state) {
		setContentDescription(state.contentDescription);
		if (mState.visible != state.visible \|\| mState.provisioned != state.provisioned) {
		mMobileGroup.setVisibility(state.visible && state.provisioned
		? View.VISIBLE : View.GONE);
		}
		if (mState.strengthId != state.strengthId) {
		mMobileDrawable.setLevel(state.strengthId);
		}