Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6581930b authored by Joy Babafemi's avatar Joy Babafemi
Browse files

Set dropdown presentation content description programmatically to provider name

Bug: 322439176
Change-Id: I4a222b9b07d3d48a47184601ebfcc0d70a826b9c
parent a2d78978
Loading
Loading
Loading
Loading
+1 −0
Original line number Original line Diff line number Diff line
@@ -3,6 +3,7 @@
    android:height="24dp"
    android:height="24dp"
    android:viewportWidth="960"
    android:viewportWidth="960"
    android:viewportHeight="960"
    android:viewportHeight="960"
    android:contentDescription="@string/more_options_content_description"
    android:tint="?attr/colorControlNormal">
    android:tint="?attr/colorControlNormal">
  <path
  <path
      android:fillColor="@android:color/white"
      android:fillColor="@android:color/white"
+1 −1
Original line number Original line Diff line number Diff line
@@ -28,7 +28,7 @@
        android:layout_height="wrap_content"
        android:layout_height="wrap_content"
        android:layout_centerVertical="true"
        android:layout_centerVertical="true"
        android:layout_alignParentStart="true"
        android:layout_alignParentStart="true"
        android:contentDescription="@string/provider_icon_content_description"
        android:contentDescription="@string/more_options_content_description"
        android:background="@null"/>
        android:background="@null"/>
    <TextView
    <TextView
        android:id="@android:id/text1"
        android:id="@android:id/text1"
+0 −1
Original line number Original line Diff line number Diff line
@@ -25,7 +25,6 @@
            android:id="@android:id/icon1"
            android:id="@android:id/icon1"
            android:layout_width="wrap_content"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_height="wrap_content"
            android:contentDescription="@string/dropdown_presentation_more_sign_in_options_text"
            android:layout_centerVertical="true"
            android:layout_centerVertical="true"
            android:layout_alignParentStart="true"
            android:layout_alignParentStart="true"
            android:background="@null"/>
            android:background="@null"/>
+1 −1
Original line number Original line Diff line number Diff line
@@ -172,5 +172,5 @@
  <!-- Strings for dropdown presentation. -->
  <!-- Strings for dropdown presentation. -->
  <!-- Text shown in the dropdown presentation to select more sign in options. [CHAR LIMIT=120] -->
  <!-- Text shown in the dropdown presentation to select more sign in options. [CHAR LIMIT=120] -->
  <string name="dropdown_presentation_more_sign_in_options_text">Sign-in options</string>
  <string name="dropdown_presentation_more_sign_in_options_text">Sign-in options</string>
  <string name="provider_icon_content_description">Credential provider icon</string>
  <string name="more_options_content_description">More</string>
</resources>
</resources>
 No newline at end of file
+2 −0
Original line number Original line Diff line number Diff line
@@ -74,6 +74,8 @@ class RemoteViewsFactory {
                    setMaxHeightMethodName,
                    setMaxHeightMethodName,
                    context.resources.getDimensionPixelSize(
                    context.resources.getDimensionPixelSize(
                            com.android.credentialmanager.R.dimen.autofill_icon_size));
                            com.android.credentialmanager.R.dimen.autofill_icon_size));
            remoteViews.setContentDescription(android.R.id.icon1, credentialEntryInfo
                    .providerDisplayName);
            val drawableId =
            val drawableId =
                    com.android.credentialmanager.R.drawable.fill_dialog_dynamic_list_item_one
                    com.android.credentialmanager.R.drawable.fill_dialog_dynamic_list_item_one
            remoteViews.setInt(
            remoteViews.setInt(