Add cross user permission check - areNotificationsEnabledForPackage (657d1641) · Commits · e / os / android_frameworks_base

services/core/java/com/android/server/notification/NotificationManagerService.java

+5 −0

Original line number	Diff line number	Diff line
		@@ -2406,6 +2406,11 @@ public class NotificationManagerService extends SystemService {
		@Override
		public boolean areNotificationsEnabledForPackage(String pkg, int uid) {
		checkCallerIsSystemOrSameApp(pkg);
		if (UserHandle.getCallingUserId() != UserHandle.getUserId(uid)) {
		getContext().enforceCallingPermission(
		android.Manifest.permission.INTERACT_ACROSS_USERS,
		"canNotifyAsPackage for uid " + uid);
		}

		return mPreferencesHelper.getImportance(pkg, uid) != IMPORTANCE_NONE;
		}

+16 −0

Original line number	Diff line number	Diff line
		@@ -4324,4 +4324,20 @@ public class NotificationManagerServiceTest extends UiServiceTestCase {
		assertEquals(IMPORTANCE_LOW, r.getAssistantImportance());
		assertEquals(USER_SENTIMENT_NEUTRAL, r.getUserSentiment());
		}

		public void testAreNotificationsEnabledForPackage_crossUser() throws Exception {
		try {
		mBinderService.areNotificationsEnabledForPackage(mContext.getPackageName(),
		mUid + UserHandle.PER_USER_RANGE);
		fail("Cannot call cross user without permission");
		} catch (SecurityException e) {
		// pass
		}

		// cross user, with permission, no problem
		TestablePermissions perms = mContext.getTestablePermissions();
		perms.setPermission(android.Manifest.permission.INTERACT_ACROSS_USERS, PERMISSION_GRANTED);
		mBinderService.areNotificationsEnabledForPackage(mContext.getPackageName(),
		mUid + UserHandle.PER_USER_RANGE);
		}
		}