Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6566fbe9 authored by Jeff Sharkey's avatar Jeff Sharkey Committed by Jeff Sharkey
Browse files

Public volumes belong to a single user. 

When a public (vfat) device is inserted, it's strongly associated
with the current foreground user, and no other users should be able
to access it, since otherwise that would be a cross-user data leak.

To use the device under a different user, switch users and then
eject/remount the device.

Test: verified user isolation of USB drive
Bug: 32523490
Change-Id: I590c791996f1fea8d78f625dc942d149f1f41614
parent afbf16f9

packages/ExternalStorageProvider/src/com/android/externalstorage/ExternalStorageProvider.java

+2 −1
Original line number Diff line number Diff line
@@ -161,7 +161,8 @@ public class ExternalStorageProvider extends DocumentsProvider { 
                    final VolumeInfo privateVol = mStorageManager.findPrivateForEmulated(volume);

                    title = mStorageManager.getBestVolumeDescription(privateVol);

                }

            } else if (volume.getType() == VolumeInfo.TYPE_PUBLIC) {

            } else if (volume.getType() == VolumeInfo.TYPE_PUBLIC

                    && volume.getMountUserId() == userId) {

                rootId = volume.getFsUuid();

                title = mStorageManager.getBestVolumeDescription(volume);

            } else {