Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 653a725a authored by Evan Rosky's avatar Evan Rosky
Browse files

Post insets update to handler 

Otherwise there is a potential race with accessors of
mInsetsState

Bug: 157581406
Test: TaplTestsQuickstep.testAllAppsFromHome
Change-Id: I15719dde23464e15edee6597e117a731419d9253
parent 4911db03

packages/SystemUI/src/com/android/systemui/wm/DisplayImeController.java

+105 −105
Original line number Diff line number Diff line
@@ -187,6 +187,7 @@ public class DisplayImeController implements DisplayController.OnDisplaysChanged 


        @Override

        public void insetsChanged(InsetsState insetsState) {

            mHandler.post(() -> {

                if (mInsetsState.equals(insetsState)) {

                    return;

                }
@@ -200,6 +201,7 @@ public class DisplayImeController implements DisplayController.OnDisplaysChanged 
                    if (DEBUG) Slog.d(TAG, "insetsChanged when IME showing, restart animation");

                    startAnimation(mImeShowing, true /* forceRestart */);

                }

            });

        }



        @Override
@@ -232,7 +234,7 @@ public class DisplayImeController implements DisplayController.OnDisplaysChanged 
                return;

            }

            if (DEBUG) Slog.d(TAG, "Got showInsets for ime");

            startAnimation(true /* show */, false /* forceRestart */);

            mHandler.post(() -> startAnimation(true /* show */, false /* forceRestart */));

        }



        @Override
@@ -241,7 +243,7 @@ public class DisplayImeController implements DisplayController.OnDisplaysChanged 
                return;

            }

            if (DEBUG) Slog.d(TAG, "Got hideInsets for ime");

            startAnimation(false /* show */, false /* forceRestart */);

            mHandler.post(() -> startAnimation(false /* show */, false /* forceRestart */));

        }



        /**
@@ -269,7 +271,6 @@ public class DisplayImeController implements DisplayController.OnDisplaysChanged 
            if (newFrame.height() != 0) {

                mImeFrame.set(newFrame);

            }

            mHandler.post(() -> {

            if (DEBUG) {

                Slog.d(TAG, "Run startAnim  show:" + show + "  was:"

                        + (mAnimationDirection == DIRECTION_SHOW ? "SHOW"
@@ -370,7 +371,6 @@ public class DisplayImeController implements DisplayController.OnDisplaysChanged 
                // can have a "flicker" of ime-provided insets.

                setVisibleDirectly(true /* visible */);

            }

            });

        }

    }