Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 64d4a390 authored by Ibrahim Yilmaz's avatar Ibrahim Yilmaz
Browse files

Remove spammy height update logs 

Height update logs are very spammy and make debugging very hard. This CL removes these logs but they can be added back differently.

Bug: 424163539
Flag: EXEMPT log cleaning
Test: Presubmit
Change-Id: Ic211d694347a3ca6135ced720aceaf417d7b6e90
parent 2d094810

packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java

+9 −3
Original line number Diff line number Diff line
@@ -4695,9 +4695,8 @@ public class NotificationStackScrollLayout 
        ExpandableView firstVisibleChild =

                firstSection == null ? null : firstSection.getFirstVisibleChild();

        if (row != null) {

            if (mLogger != null) {

                mLogger.childHeightUpdated(row, needsAnimation);

            }

            // TODO(b/424163539): child height updated logs are spammy, which hides other logs

            // logChildHeightUpdated(row, needsAnimation);

            if (row == firstVisibleChild

                    || row.getNotificationParent() == firstVisibleChild) {

                updateAlgorithmLayoutMinHeight();
@@ -4711,6 +4710,13 @@ public class NotificationStackScrollLayout 
        mAnimateStackYForContentHeightChange = previouslyNeededAnimation;

    }





    private void logChildHeightUpdated(ExpandableNotificationRow row, boolean needsAnimation) {

        if (mLogger != null) {

            mLogger.childHeightUpdated(row, needsAnimation);

        }

    }



    void onChildHeightReset(ExpandableView view) {

        updateAnimationState(view);

        updateChronometerForChild(view);

packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/domain/interactor/SharedNotificationContainerInteractor.kt

+2 −1
Original line number Diff line number Diff line
@@ -138,7 +138,8 @@ constructor( 


    /** An internal modification was made to notifications */

    fun notificationStackChanged() {

        logger?.notificationStackChanged()

        // TODO(b/424163539): child height updated logs are spammy, which hides other logs

        // logger?.notificationStackChanged()

        notificationStackChangedDebounced.value = notificationStackChangedDebounced.value + 1

    }