Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63af3f6e authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Automerger Merge Worker
Browse files

Merge "Remove obsolete/infeasible TODOs" into rvc-dev am: d5729ebc 

Change-Id: I7602a2d499f5d13fc0cdfbeaa41d3d0028addcbd
parents aa3dc3d9 d5729ebc

cmds/statsd/src/logd/LogEvent.h

+0 −3
Original line number Diff line number Diff line
@@ -218,9 +218,6 @@ private: 
     * The below three variables are only valid during the execution of

     * parseBuffer. There are no guarantees about the state of these variables

     * before/after.

     *

     * TODO (b/150312423): These shouldn't be member variables. We should pass

     * them around as parameters.

     */

    uint8_t* mBuf;

    uint32_t mRemainingLen; // number of valid bytes left in the buffer being parsed

cmds/statsd/src/shell/ShellSubscriber.cpp

+0 −1
Original line number Diff line number Diff line
@@ -152,7 +152,6 @@ void ShellSubscriber::startPull(int64_t myToken) { 
                mPullerMgr->Pull(pullInfo.mPullerMatcher.atom_id(), uids, &data);

                VLOG("pulled %zu atoms with id %d", data.size(), pullInfo.mPullerMatcher.atom_id());



                // TODO(b/150969574): Don't write to a pipe while holding a lock.

                if (!writePulledAtomsLocked(data, pullInfo.mPullerMatcher)) {

                    mSubscriptionInfo->mClientAlive = false;

                    mSubscriptionShouldEnd.notify_one();