Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6397ab54 authored by Jeremy Joslin's avatar Jeremy Joslin
Browse files

Check for REQUEST_NETWORK_SCORES instead of BROADCAST_NETWORK_PRIVILEGED. 

Test: runtest frameworks-services -c com.android.server.NetworkScoreServiceTest
BUG: 33752149
Change-Id: If261cf25c227eeeb4155e43afd9354e6ff8df3b4
parent 26a45e5b

services/core/java/com/android/server/NetworkScoreService.java

+1 −1
Original line number Diff line number Diff line
@@ -604,7 +604,7 @@ public class NetworkScoreService extends INetworkScoreService.Stub { 
    @Override

    public void requestRecommendationAsync(RecommendationRequest request,

            RemoteCallback remoteCallback) {

        mContext.enforceCallingOrSelfPermission(permission.BROADCAST_NETWORK_PRIVILEGED, TAG);

        mContext.enforceCallingOrSelfPermission(permission.REQUEST_NETWORK_SCORES, TAG);



        final OneTimeCallback oneTimeCallback = new OneTimeCallback(remoteCallback);

        final Pair<RecommendationRequest, OneTimeCallback> pair =

services/tests/servicestests/src/com/android/server/NetworkScoreServiceTest.java

+2 −2
Original line number Diff line number Diff line
@@ -290,12 +290,12 @@ public class NetworkScoreServiceTest { 
    @Test

    public void testRequestRecommendationAsync_noPermission() throws Exception {

        doThrow(new SecurityException()).when(mContext)

                .enforceCallingOrSelfPermission(eq(permission.BROADCAST_NETWORK_PRIVILEGED),

                .enforceCallingOrSelfPermission(eq(permission.REQUEST_NETWORK_SCORES),

                        anyString());

        try {

            mNetworkScoreService.requestRecommendationAsync(mRecommendationRequest,

                    mRemoteCallback);

            fail("BROADCAST_NETWORK_PRIVILEGED not enforced.");

            fail("REQUEST_NETWORK_SCORES not enforced.");

        } catch (SecurityException e) {

            // expected

        }