Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 63754291 authored by Treehugger Robot's avatar Treehugger Robot Committed by Android (Google) Code Review
Browse files

Merge "On exiting PiP reset override to inherit values from parent" into main

parents a3707075 e5b8ef3a

services/core/java/com/android/server/wm/ActivityRecord.java

+4 −4
Original line number Diff line number Diff line
@@ -7616,10 +7616,10 @@ final class ActivityRecord extends WindowToken { 
                    requestedOverrideConfig.densityDpi = lastReportedMergedConfig.densityDpi;

                }

            } else {

                // Update the configs if we're exiting PiP mode.

                requestedOverrideConfig.colorMode = newParentConfiguration.colorMode;

                requestedOverrideConfig.touchscreen = newParentConfiguration.touchscreen;

                requestedOverrideConfig.densityDpi = newParentConfiguration.densityDpi;

                // Reset the configs if we're exiting PiP mode.

                requestedOverrideConfig.colorMode = Configuration.COLOR_MODE_UNDEFINED;

                requestedOverrideConfig.touchscreen = Configuration.TOUCHSCREEN_UNDEFINED;

                requestedOverrideConfig.densityDpi = Configuration.DENSITY_DPI_UNDEFINED;

            }

        }

services/tests/wmtests/src/com/android/server/wm/ActivityRecordTests.java

+21 −15
Original line number Diff line number Diff line
@@ -3586,9 +3586,9 @@ public class ActivityRecordTests extends WindowTestsBase { 
        newConfig.colorMode = COLOR_MODE_WIDE_COLOR_GAMUT_YES;

        activity.resolveOverrideConfiguration(newConfig);



        assertEquals(activity.getRequestedOverrideConfiguration().touchscreen, config.touchscreen);

        assertEquals(activity.getRequestedOverrideConfiguration().densityDpi, config.densityDpi);

        assertEquals(activity.getRequestedOverrideConfiguration().colorMode, config.colorMode);

        assertEquals(config.touchscreen, activity.getRequestedOverrideConfiguration().touchscreen);

        assertEquals(config.densityDpi, activity.getRequestedOverrideConfiguration().densityDpi);

        assertEquals(config.colorMode, activity.getRequestedOverrideConfiguration().colorMode);

    }



    @Test
@@ -3610,10 +3610,12 @@ public class ActivityRecordTests extends WindowTestsBase { 
        newConfig.colorMode = COLOR_MODE_WIDE_COLOR_GAMUT_YES;

        activity.resolveOverrideConfiguration(newConfig);



        assertNotEquals(activity.getRequestedOverrideConfiguration().touchscreen,

                config.touchscreen);

        assertNotEquals(activity.getRequestedOverrideConfiguration().densityDpi, config.densityDpi);

        assertNotEquals(activity.getRequestedOverrideConfiguration().colorMode, config.colorMode);

        assertEquals(Configuration.TOUCHSCREEN_UNDEFINED,

                activity.getRequestedOverrideConfiguration().touchscreen);

        assertEquals(Configuration.DENSITY_DPI_UNDEFINED,

                activity.getRequestedOverrideConfiguration().densityDpi);

        assertEquals(Configuration.COLOR_MODE_UNDEFINED,

                activity.getRequestedOverrideConfiguration().colorMode);

    }



    @Test
@@ -3632,10 +3634,12 @@ public class ActivityRecordTests extends WindowTestsBase { 
        newConfig.colorMode = COLOR_MODE_WIDE_COLOR_GAMUT_YES;

        activity.resolveOverrideConfiguration(newConfig);



        assertNotEquals(activity.getRequestedOverrideConfiguration().touchscreen,

                config.touchscreen);

        assertNotEquals(activity.getRequestedOverrideConfiguration().densityDpi, config.densityDpi);

        assertNotEquals(activity.getRequestedOverrideConfiguration().colorMode, config.colorMode);

        assertEquals(Configuration.TOUCHSCREEN_UNDEFINED,

                activity.getRequestedOverrideConfiguration().touchscreen);

        assertEquals(Configuration.DENSITY_DPI_UNDEFINED,

                activity.getRequestedOverrideConfiguration().densityDpi);

        assertEquals(Configuration.COLOR_MODE_UNDEFINED,

                activity.getRequestedOverrideConfiguration().colorMode);

    }



    @Test
@@ -3656,10 +3660,12 @@ public class ActivityRecordTests extends WindowTestsBase { 
        newConfig.colorMode = COLOR_MODE_WIDE_COLOR_GAMUT_YES;

        activity.resolveOverrideConfiguration(newConfig);



        assertEquals(activity.getRequestedOverrideConfiguration().touchscreen,

                newConfig.touchscreen);

        assertEquals(activity.getRequestedOverrideConfiguration().densityDpi, newConfig.densityDpi);

        assertEquals(activity.getRequestedOverrideConfiguration().colorMode, newConfig.colorMode);

        assertEquals(Configuration.TOUCHSCREEN_UNDEFINED,

                activity.getRequestedOverrideConfiguration().touchscreen);

        assertEquals(Configuration.DENSITY_DPI_UNDEFINED,

                activity.getRequestedOverrideConfiguration().densityDpi);

        assertEquals(Configuration.COLOR_MODE_UNDEFINED,

                activity.getRequestedOverrideConfiguration().colorMode);

    }



    private ActivityRecord setupDisplayAndActivityForCameraCompat(boolean isCameraRunning,