Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 634a69b7 authored by Ioana Alexandru's avatar Ioana Alexandru
Browse files

Visit URIs in themed remoteviews icons. 

Bug: 281018094
Test: atest RemoteViewsTest NotificationVisitUrisTest
Change-Id: I2014bf21cf90267f7f1b3f370bf00ab7001b064e
Merged-In: I2014bf21cf90267f7f1b3f370bf00ab7001b064e
parent b50f8cd5

core/java/android/widget/RemoteViews.java

+9 −1
Original line number Diff line number Diff line
@@ -1744,7 +1744,7 @@ public class RemoteViews implements Parcelable, Filter { 
        }



        @Override

        public final void visitUris(@NonNull Consumer<Uri> visitor) {

        public void visitUris(@NonNull Consumer<Uri> visitor) {

            switch (this.type) {

                case URI:

                    final Uri uri = (Uri) getParameterValue(null);
@@ -2196,6 +2196,14 @@ public class RemoteViews implements Parcelable, Filter { 
        public int getActionTag() {

            return NIGHT_MODE_REFLECTION_ACTION_TAG;

        }



        @Override

        public void visitUris(@NonNull Consumer<Uri> visitor) {

            if (this.type == ICON) {

                visitIconUri((Icon) mDarkValue, visitor);

                visitIconUri((Icon) mLightValue, visitor);

            }

        }

    }



    /**

core/tests/coretests/src/android/widget/RemoteViewsTest.java

+13 −0
Original line number Diff line number Diff line
@@ -528,6 +528,19 @@ public class RemoteViewsTest { 
        verify(visitor, times(1)).accept(eq(icon4.getUri()));

    }



    @Test

    public void visitUris_themedIcons() {

        RemoteViews views = new RemoteViews(mPackage, R.layout.remote_views_test);

        final Icon iconLight = Icon.createWithContentUri("content://light/icon");

        final Icon iconDark = Icon.createWithContentUri("content://dark/icon");

        views.setIcon(R.id.layout, "setLargeIcon", iconLight, iconDark);



        Consumer<Uri> visitor = (Consumer<Uri>) spy(Consumer.class);

        views.visitUris(visitor);

        verify(visitor, times(1)).accept(eq(iconLight.getUri()));

        verify(visitor, times(1)).accept(eq(iconDark.getUri()));

    }



    @Test

    public void visitUris_nestedViews() {

        final RemoteViews outer = new RemoteViews(mPackage, R.layout.remote_views_test);