Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6335ad65 authored by Robin Lee's avatar Robin Lee
Browse files

Move keyguard enabled to Component Override 

When using RROs, android:enabled="@bool/form_factor_flag" won't work any
more. So we need to use a component override flag per b/135048762.

Test: Flash an adt3 with RRO enabled. see that systemui is coming up.
Bug: 173138807
Change-Id: If9a99f850ebb34755b4146b786c189f9fb590c3d
parent b2788d44

packages/SystemUI/AndroidManifest.xml

+1 −2
Original line number Diff line number Diff line
@@ -623,8 +623,7 @@ 


        <service

            android:name=".keyguard.KeyguardService"

            android:exported="true"

            android:enabled="@bool/config_enableKeyguardService" />

            android:exported="true" />



        <activity android:name=".keyguard.WorkLockActivity"

                  android:label="@string/accessibility_desc_work_lock"

packages/SystemUI/res/values-television/config.xml

+0 −3
Original line number Diff line number Diff line
@@ -44,9 +44,6 @@ 
        <item>com.android.systemui.wmshell.WMShell</item>

    </string-array>



    <!-- Disable KeyguardService -->

    <bool name="config_enableKeyguardService">false</bool>



    <!-- Svelte specific logic, see RecentsConfiguration.SVELTE_* constants. -->

    <integer name="recents_svelte_level">3</integer>

packages/SystemUI/res/values/config.xml

+0 −3
Original line number Diff line number Diff line
@@ -161,9 +161,6 @@ 
    <!-- The number of milliseconds to extend ambient pulse by when prompted (e.g. on touch) -->

    <integer name="ambient_notification_extension_time">10000</integer>



    <!-- Whether to enable KeyguardService or not -->

    <bool name="config_enableKeyguardService">true</bool>



    <!-- The maximum count of notifications on Keyguard. The rest will be collapsed in an overflow

     card. -->

    <integer name="keyguard_max_notification_count">3</integer>

packages/SystemUI/src/com/android/systemui/keyguard/KeyguardViewMediator.java

+13 −1
Original line number Diff line number Diff line
@@ -34,10 +34,12 @@ import android.app.PendingIntent; 
import android.app.StatusBarManager;

import android.app.trust.TrustManager;

import android.content.BroadcastReceiver;

import android.content.ComponentName;

import android.content.ContentResolver;

import android.content.Context;

import android.content.Intent;

import android.content.IntentFilter;

import android.content.pm.PackageManager.NameNotFoundException;

import android.content.pm.UserInfo;

import android.hardware.biometrics.BiometricSourceType;

import android.media.AudioAttributes;
@@ -88,6 +90,7 @@ import com.android.systemui.SystemUI; 
import com.android.systemui.broadcast.BroadcastDispatcher;

import com.android.systemui.dagger.qualifiers.UiBackground;

import com.android.systemui.dump.DumpManager;

import com.android.systemui.keyguard.KeyguardService;

import com.android.systemui.keyguard.dagger.KeyguardModule;

import com.android.systemui.navigationbar.NavigationModeController;

import com.android.systemui.plugins.FalsingManager;
@@ -779,7 +782,7 @@ public class KeyguardViewMediator extends SystemUI implements Dumpable { 


        // Assume keyguard is showing (unless it's disabled) until we know for sure, unless Keyguard

        // is disabled.

        if (mContext.getResources().getBoolean(R.bool.config_enableKeyguardService)) {

        if (isKeyguardServiceEnabled()) {

            setShowingLocked(!shouldWaitForProvisioning()

                    && !mLockPatternUtils.isLockScreenDisabled(

                            KeyguardUpdateMonitor.getCurrentUser()), true /* forceCallbacks */);
@@ -957,6 +960,15 @@ public class KeyguardViewMediator extends SystemUI implements Dumpable { 
        mUpdateMonitor.dispatchFinishedGoingToSleep(why);

    }



    private boolean isKeyguardServiceEnabled() {

        try {

            return mContext.getPackageManager().getServiceInfo(

                    new ComponentName(mContext, KeyguardService.class), 0).isEnabled();

        } catch (NameNotFoundException e) {

            return true;

        }

    }



    private long getLockTimeout(int userId) {

        // if the screen turned off because of timeout or the user hit the power button

        // and we don't need to lock immediately, set an alarm