Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 626afea1 authored by Anton Hansson's avatar Anton Hansson
Browse files

Enable compat checking & lint for module_lib api 

These were previously turned off as there were no previous
releases to compare it to. Check in empty files as comparison.

The new tethering APIs fail lint -- I have filed a release
blocking bug to get these cleaned up.

Bug: 149430003
Bug: 147559833
Test: m module-lib-api-api-lint
Test: m module-lib-api-check-last-released-api (with+without incompatibilities)
Change-Id: I2b171dc836ca121502fb345d8dd512a05c566a49
Merged-In: I2b171dc836ca121502fb345d8dd512a05c566a49
(cherry picked from commit 79e35c3b)
parent 195fc891

StubLibraries.bp

+10 −13
Original line number Diff line number Diff line
@@ -193,20 +193,17 @@ droidstubs { 
            api_file: "api/module-lib-current.txt",

            removed_api_file: "api/module-lib-removed.txt",

        },

        // TODO(b/147559833) enable the compatibility check against the last release API

        // and the API lint

        //last_released: {

        //    api_file: ":last-released-module-lib-api",

        //    removed_api_file: "api/module-lib-removed.txt",

        //    baseline_file: ":module-lib-api-incompatibilities-with-last-released"

        //},

        //api_lint: {

        //    enabled: true,

        //    new_since: ":last-released-module-lib-api",

        //    baseline_file: "api/module-lib-lint-baseline.txt",

        //},

        last_released: {

            api_file: ":last-released-module-lib-api",

            removed_api_file: "api/module-lib-removed.txt",

            baseline_file: ":module-lib-api-incompatibilities-with-last-released"

        },

        api_lint: {

            enabled: true,

            new_since: ":last-released-module-lib-api",

            baseline_file: "api/module-lib-lint-baseline.txt",

        },

    },

    //jdiff_enabled: true,

}

api/module-lib-lint-baseline.txt

0 → 100644
+33 −0
Original line number Diff line number Diff line 
// Baseline format: 1.0

ActionValue: android.net.TetheringConstants#EXTRA_ADD_TETHER_TYPE:

    Inconsistent extra value; expected `android.net.extra.ADD_TETHER_TYPE`, was `extraAddTetherType`

ActionValue: android.net.TetheringConstants#EXTRA_PROVISION_CALLBACK:

    Inconsistent extra value; expected `android.net.extra.PROVISION_CALLBACK`, was `extraProvisionCallback`

ActionValue: android.net.TetheringConstants#EXTRA_REM_TETHER_TYPE:

    Inconsistent extra value; expected `android.net.extra.REM_TETHER_TYPE`, was `extraRemTetherType`

ActionValue: android.net.TetheringConstants#EXTRA_RUN_PROVISION:

    Inconsistent extra value; expected `android.net.extra.RUN_PROVISION`, was `extraRunProvision`

ActionValue: android.net.TetheringConstants#EXTRA_SET_ALARM:

    Inconsistent extra value; expected `android.net.extra.SET_ALARM`, was `extraSetAlarm`

ActionValue: android.net.TetheringManager#ACTION_TETHER_STATE_CHANGED:

    Inconsistent action value; expected `android.net.action.TETHER_STATE_CHANGED`, was `android.net.conn.TETHER_STATE_CHANGED`

ActionValue: android.net.TetheringManager#EXTRA_ACTIVE_TETHER:

    Inconsistent extra value; expected `android.net.extra.ACTIVE_TETHER`, was `tetherArray`

ActionValue: android.net.TetheringManager#EXTRA_AVAILABLE_TETHER:

    Inconsistent extra value; expected `android.net.extra.AVAILABLE_TETHER`, was `availableArray`

ActionValue: android.net.TetheringManager#EXTRA_ERRORED_TETHER:

    Inconsistent extra value; expected `android.net.extra.ERRORED_TETHER`, was `erroredArray`





ManagerConstructor: android.net.TetheringManager#TetheringManager(android.content.Context, java.util.function.Supplier<android.os.IBinder>):

    Managers must always be obtained from Context; no direct constructors





PrivateSuperclass: android.location.GnssAntennaInfo.PhaseCenterVariationCorrections:

    Public class android.location.GnssAntennaInfo.PhaseCenterVariationCorrections extends private class android.location.GnssAntennaInfo.SphericalCorrections

PrivateSuperclass: android.location.GnssAntennaInfo.SignalGainCorrections:

    Public class android.location.GnssAntennaInfo.SignalGainCorrections extends private class android.location.GnssAntennaInfo.SphericalCorrections





StaticUtils: android.net.TetheringConstants:

    Fully-static utility classes must not have constructor