Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61f869e7 authored by Tej Singh's avatar Tej Singh
Browse files

Incident dump does not include current bucket 

This is to avoid value metrics skipping buckets due to
DUMP_REPORT_REQUESTED, since if the metric needs to include the current
bucket under time constraints and needs to pull, it will drop the bucket
since it cannot pull.

Test: atest statsd_test
Bug: 158879346
Change-Id: Ia61e69530456ce2b3530add03ec6e068ffb25fb5
parent 4c65d2cb

cmds/statsd/src/StatsService.cpp

+4 −1
Original line number Diff line number Diff line
@@ -267,8 +267,11 @@ void StatsService::dumpIncidentSection(int out) { 
    for (const ConfigKey& configKey : mConfigManager->GetAllConfigKeys()) {

        uint64_t reportsListToken =

                proto.start(FIELD_TYPE_MESSAGE | FIELD_COUNT_REPEATED | FIELD_ID_REPORTS_LIST);

        // Don't include the current bucket to avoid skipping buckets.

        // If we need to include the current bucket later, consider changing to NO_TIME_CONSTRAINTS

        // or other alternatives to avoid skipping buckets for pulled metrics.

        mProcessor->onDumpReport(configKey, getElapsedRealtimeNs(),

                                 true /* includeCurrentBucket */, false /* erase_data */,

                                 false /* includeCurrentBucket */, false /* erase_data */,

                                 ADB_DUMP,

                                 FAST,

                                 &proto);