Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 619a511d authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

StrictMode to detect untagged network traffic. 

Network usage is tracked by the kernel at the UID level, which is
granular enough for normal apps, but large components (such as the
system server) are impossible to debug without adding additional
socket tagging to help identify subsystems within a UID.

To help ensure that system components tag all their network traffic,
this change offers a new StrictMode option to detect and report
untagged sockets.

Test: builds, boots, all common traffic tagged
Bug: 30943431, 30414041
Change-Id: I825c7941076054732264690247de2863342638e2
parent 063c454b

api/current.txt

+2 −0
Original line number Diff line number Diff line
@@ -24481,6 +24481,7 @@ package android.net { 
  public class TrafficStats {

    ctor public TrafficStats();

    method public static void clearThreadStatsTag();

    method public static int getAndSetThreadStatsTag(int);

    method public static long getMobileRxBytes();

    method public static long getMobileRxPackets();

    method public static long getMobileTxBytes();
@@ -30062,6 +30063,7 @@ package android.os { 
    method public android.os.StrictMode.VmPolicy.Builder detectLeakedClosableObjects();

    method public android.os.StrictMode.VmPolicy.Builder detectLeakedRegistrationObjects();

    method public android.os.StrictMode.VmPolicy.Builder detectLeakedSqlLiteObjects();

    method public android.os.StrictMode.VmPolicy.Builder detectUntaggedSockets();

    method public android.os.StrictMode.VmPolicy.Builder penaltyDeath();

    method public android.os.StrictMode.VmPolicy.Builder penaltyDeathOnCleartextNetwork();

    method public android.os.StrictMode.VmPolicy.Builder penaltyDeathOnFileUriExposure();

api/system-current.txt

+2 −0
Original line number Diff line number Diff line
@@ -26460,6 +26460,7 @@ package android.net { 
    ctor public TrafficStats();

    method public static void clearThreadStatsTag();

    method public static void clearThreadStatsUid();

    method public static int getAndSetThreadStatsTag(int);

    method public static long getMobileRxBytes();

    method public static long getMobileRxPackets();

    method public static long getMobileTxBytes();
@@ -32706,6 +32707,7 @@ package android.os { 
    method public android.os.StrictMode.VmPolicy.Builder detectLeakedClosableObjects();

    method public android.os.StrictMode.VmPolicy.Builder detectLeakedRegistrationObjects();

    method public android.os.StrictMode.VmPolicy.Builder detectLeakedSqlLiteObjects();

    method public android.os.StrictMode.VmPolicy.Builder detectUntaggedSockets();

    method public android.os.StrictMode.VmPolicy.Builder penaltyDeath();

    method public android.os.StrictMode.VmPolicy.Builder penaltyDeathOnCleartextNetwork();

    method public android.os.StrictMode.VmPolicy.Builder penaltyDeathOnFileUriExposure();

api/test-current.txt

+2 −0
Original line number Diff line number Diff line
@@ -24571,6 +24571,7 @@ package android.net { 
  public class TrafficStats {

    ctor public TrafficStats();

    method public static void clearThreadStatsTag();

    method public static int getAndSetThreadStatsTag(int);

    method public static long getMobileRxBytes();

    method public static long getMobileRxPackets();

    method public static long getMobileTxBytes();
@@ -30174,6 +30175,7 @@ package android.os { 
    method public android.os.StrictMode.VmPolicy.Builder detectLeakedClosableObjects();

    method public android.os.StrictMode.VmPolicy.Builder detectLeakedRegistrationObjects();

    method public android.os.StrictMode.VmPolicy.Builder detectLeakedSqlLiteObjects();

    method public android.os.StrictMode.VmPolicy.Builder detectUntaggedSockets();

    method public android.os.StrictMode.VmPolicy.Builder penaltyDeath();

    method public android.os.StrictMode.VmPolicy.Builder penaltyDeathOnCleartextNetwork();

    method public android.os.StrictMode.VmPolicy.Builder penaltyDeathOnFileUriExposure();

core/java/android/net/SntpClient.java

+2 −0
Original line number Diff line number Diff line
@@ -96,6 +96,7 @@ public class SntpClient { 


    public boolean requestTime(InetAddress address, int port, int timeout) {

        DatagramSocket socket = null;

        final int oldTag = TrafficStats.getAndSetThreadStatsTag(TrafficStats.TAG_SYSTEM_NTP);

        try {

            socket = new DatagramSocket();

            socket.setSoTimeout(timeout);
@@ -161,6 +162,7 @@ public class SntpClient { 
            if (socket != null) {

                socket.close();

            }

            TrafficStats.setThreadStatsTag(oldTag);

        }



        return true;

core/java/android/net/TrafficStats.java

+18 −0
Original line number Diff line number Diff line
@@ -166,6 +166,24 @@ public class TrafficStats { 
        NetworkManagementSocketTagger.setThreadSocketStatsTag(tag);

    }



    /**

     * Set active tag to use when accounting {@link Socket} traffic originating

     * from the current thread. Only one active tag per thread is supported.

     * <p>

     * Changes only take effect during subsequent calls to

     * {@link #tagSocket(Socket)}.

     * <p>

     * Tags between {@code 0xFFFFFF00} and {@code 0xFFFFFFFF} are reserved and

     * used internally by system services like {@link DownloadManager} when

     * performing traffic on behalf of an application.

     *

     * @return the current tag for the calling thread, which can be used to

     *         restore any existing values after a nested operation is finished

     */

    public static int getAndSetThreadStatsTag(int tag) {

        return NetworkManagementSocketTagger.setThreadSocketStatsTag(tag);

    }



    /**

     * Set active tag to use when accounting {@link Socket} traffic originating

     * from the current thread. The tag used internally is well-defined to