Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60b062f7 authored by Wilson Wu's avatar Wilson Wu
Browse files

[RESTRICT AUTOMERGE] Make MultiClient IMMS PendingIntent IMMUTABLE 

Unsafe PendingIntent could lead to security problem.

Bug: 203777141
Test: Manual test by PoC in bug
Test: presubmit
Change-Id: I22adf0a5c9032852026cd23d10b9a2328cdf1426
parent f2166b37

services/core/java/com/android/server/inputmethod/MultiClientInputMethodManagerService.java

+1 −1
Original line number Diff line number Diff line
@@ -917,7 +917,7 @@ public final class MultiClientInputMethodManagerService { 
                            .putExtra(Intent.EXTRA_CLIENT_INTENT, PendingIntent.getActivity(

                                    context, 0,

                                    new Intent(Settings.ACTION_INPUT_METHOD_SETTINGS),

                                    PendingIntent.FLAG_MUTABLE));

                                    PendingIntent.FLAG_IMMUTABLE));



            // Note: Instead of re-dispatching callback from the main thread to the worker thread

            // where OnWorkerThreadCallback is running, we pass the Handler object here so that