Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 609ae17f authored by Hongwei Wang's avatar Hongwei Wang
Browse files

Take task snapshot on exiting PiP 

When expanding PiP to full-screen, we first keep Task windowing mode to
be pinned and therefore, the behind Task is going to be invisible and
misses the chance to take the task snapshot.

Fix the issue by forcefully take task snapshot when the Task windowing
mode is toggled.

Flag: EXEMPT bugfix
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/gvNLaUdJmwBpmtJ4VTxqCt
Bug: 342310361
Test: Expand PiP to full-screen with other app in foreground
Change-Id: I8ed6d1b41860c702d71e73d0702e835fcddea6a2
parent 68be647c

services/core/java/com/android/server/wm/Task.java

+9 −0
Original line number Diff line number Diff line
@@ -4689,6 +4689,15 @@ class Task extends TaskFragment { 
                // it does not follow the ActivityStarter path.

                if (topActivity.shouldBeVisible()) {

                    mAtmService.resumeAppSwitches();

                    // In pip1, when expanding pip to full-screen, the "behind" task is not

                    // actually becoming invisible since task windowing mode is pinned.

                    if (!isPip2ExperimentEnabled) {

                        final ActivityRecord ar = mAtmService.mLastResumedActivity;

                        if (ar != null && ar.getTask() != null) {

                            mAtmService.takeTaskSnapshot(ar.getTask().mTaskId,

                                    true /* updateCache */);

                        }

                    }

                }

            } else if (isPip2ExperimentEnabled) {

                super.setWindowingMode(windowingMode);