Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5fb192aa authored by Prabir Pradhan's avatar Prabir Pradhan
Browse files

Remove HID usage mapping for stylus buttons in Generic.kl 

... until we figure out a way to determine if a device supports a
specific HID usage code. Right now, having a usage code mapping means we
automatically assume the device can report the key code. Assuming a
device can support a stylus keycode makes the device get classified as a
stylus, leading to widespread misclassifications.

Bug: 291529805
Test: atest inputflinger_tests
Change-Id: I580514bdcbbfbe93df83fa3faa6262077e881243
parent 3697f77a

data/keyboards/Generic.kl

+4 −2
Original line number Diff line number Diff line
@@ -439,8 +439,10 @@ key usage 0x0c007C KEYBOARD_BACKLIGHT_TOGGLE 
key usage 0x0c0173 MEDIA_AUDIO_TRACK

key usage 0x0c019C PROFILE_SWITCH

key usage 0x0c01A2 ALL_APPS

key usage 0x0d0044 STYLUS_BUTTON_PRIMARY

key usage 0x0d005a STYLUS_BUTTON_SECONDARY

# TODO(b/297094448): Add stylus button mappings as a fallback when we have a way to determine

#   if a device can actually report it.

# key usage 0x0d0044 STYLUS_BUTTON_PRIMARY

# key usage 0x0d005a STYLUS_BUTTON_SECONDARY



# Joystick and game controller axes.

# Axes that are not mapped will be assigned generic axis numbers by the input subsystem.