Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f170a57 authored by Song Chun Fan's avatar Song Chun Fan
Browse files

[ADI][metrics] log total added APKs size 

FLAG: EXEMPT fixing existing metrics
BUG: 418283971
FIXES: 418283971
Test: manually with "statsd_testdrive 1101" and installing a package

Change-Id: I38c85362d439c6ebf5f6965830d426c0df561dff
parent 2ed3c588

services/core/java/com/android/server/pm/PackageInstallerSession.java

+6 −0
Original line number Diff line number Diff line
@@ -1777,6 +1777,7 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { 
    @GuardedBy("mLock")

    private List<ApkLite> getAddedApkLitesLocked() throws PackageManagerException {

        if (!isArchivedInstallation()) {

            long addedApksSizeBytes = 0;

            List<File> files = getAddedApksLocked();

            final List<ApkLite> result = new ArrayList<>(files.size());
@@ -1790,8 +1791,13 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { 
                            parseResult.getErrorMessage(), parseResult.getException());

                }

                result.add(parseResult.getResult());

                addedApksSizeBytes += files.get(i).length();

            }



            // As a byproduct of this parsing method, also log the total size of added APK files

            synchronized (mMetrics) {

                mMetrics.onAddedApksSizeBytesCalculated(addedApksSizeBytes);

            }

            return result;

        }

services/core/java/com/android/server/pm/SessionMetrics.java

+5 −1
Original line number Diff line number Diff line
@@ -275,6 +275,10 @@ final class SessionMetrics { 
        mDeveloperVerificationCancelled = true;

    }



    public void onAddedApksSizeBytesCalculated(long apksSizeBytes) {

        mApksSizeBytes = apksSizeBytes;

    }



    private void reportStats() {

        final long sessionIdleDurationMillis = mCommittedMillis - mCreatedMillis;

        final long sessionCommitDurationMillis = mFinishedMillis - mCommittedMillis;
@@ -318,7 +322,7 @@ final class SessionMetrics { 
                        mIsPreapproval, // 21

                        mIsUnarchive, // 22

                        mIsAutoInstallDependenciesEnabled, // 23

                        mApksSizeBytes, // 24 // TODO(b/418283971): compute apks size bytes

                        mApksSizeBytes, // 24

                        getTranslatedStatusCodeForStats(

                                installStatusToPublicStatus(mStatusCode)), // 25

                        mWasUserActionIntentSent, // 26