Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ecf80ce authored by Jason Monk's avatar Jason Monk
Browse files

Fix crash when no StatusBarView 

Test: runtest systemui
Change-Id: Ia0a4a97f554e0b9d6e41c295e8e07d278f8ad248
Fixes: 63260821
parent 84e0f453

packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBar.java

+2 −1
Original line number Original line Diff line number Diff line
@@ -1022,6 +1022,7 @@ public class StatusBar extends SystemUI implements DemoMode, 
                    mStatusBarView.setBar(this);

                    mStatusBarView.setBar(this);

                    mStatusBarView.setPanel(mNotificationPanel);

                    mStatusBarView.setPanel(mNotificationPanel);

                    mStatusBarView.setScrimController(mScrimController);

                    mStatusBarView.setScrimController(mScrimController);

                    mStatusBarView.setBouncerShowing(mBouncerShowing);

                    setAreThereNotifications();

                    setAreThereNotifications();

                    checkBarModes();

                    checkBarModes();

                }).getFragmentManager()

                }).getFragmentManager()
@@ -5093,7 +5094,7 @@ public class StatusBar extends SystemUI implements DemoMode, 




    public void setBouncerShowing(boolean bouncerShowing) {

    public void setBouncerShowing(boolean bouncerShowing) {

        mBouncerShowing = bouncerShowing;

        mBouncerShowing = bouncerShowing;

        mStatusBarView.setBouncerShowing(bouncerShowing);

        if (mStatusBarView != null) mStatusBarView.setBouncerShowing(bouncerShowing);

        recomputeDisableFlags(true /* animate */);

        recomputeDisableFlags(true /* animate */);

    }

    }

packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarTest.java

+7 −0
Original line number Original line Diff line number Diff line
@@ -67,6 +67,7 @@ import com.android.keyguard.KeyguardHostView.OnDismissAction; 
import com.android.systemui.SysuiTestCase;

import com.android.systemui.SysuiTestCase;

import com.android.systemui.recents.misc.SystemServicesProxy;

import com.android.systemui.recents.misc.SystemServicesProxy;

import com.android.systemui.statusbar.ActivatableNotificationView;

import com.android.systemui.statusbar.ActivatableNotificationView;

import com.android.systemui.statusbar.CommandQueue;

import com.android.systemui.statusbar.KeyguardIndicationController;

import com.android.systemui.statusbar.KeyguardIndicationController;

import com.android.systemui.statusbar.NotificationData;

import com.android.systemui.statusbar.NotificationData;

import com.android.systemui.statusbar.NotificationData.Entry;

import com.android.systemui.statusbar.NotificationData.Entry;
@@ -155,6 +156,12 @@ public class StatusBarTest extends SysuiTestCase { 
        });

        });

    }

    }





    @Test

    public void testSetBouncerShowing_noCrash() {

        mStatusBar.mCommandQueue = mock(CommandQueue.class);

        mStatusBar.setBouncerShowing(true);

    }



    @Test

    @Test

    public void executeRunnableDismissingKeyguard_nullRunnable_showingAndOccluded() {

    public void executeRunnableDismissingKeyguard_nullRunnable_showingAndOccluded() {

        when(mStatusBarKeyguardViewManager.isShowing()).thenReturn(true);

        when(mStatusBarKeyguardViewManager.isShowing()).thenReturn(true);