Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e797faa authored by Kevin Chyn's avatar Kevin Chyn
Browse files

Revert fix for FingerprintManager leak 

Bug: 38509779
Bug: 32295793

Setting to null causes problem seen in b/38509779
Using weakreference will cause problems if the application
declares AuthenticationClient as a weak reference as well and would
very likely break a lot of existing apps.

Test: manual
Change-Id: Iedbdd76f3a402b766ce8a799bf76324d1164a0ec
parent b6d1a198

core/java/android/hardware/fingerprint/FingerprintManager.java

+0 −2
Original line number Diff line number Diff line
@@ -932,7 +932,6 @@ public class FingerprintManager { 
            } else if (mAuthenticationCallback != null) {

                mAuthenticationCallback.onAuthenticationError(clientErrMsgId,

                        getErrorString(errMsgId, vendorCode));

                mAuthenticationCallback = null;

            } else if (mRemovalCallback != null) {

                mRemovalCallback.onRemovalError(mRemovalFingerprint, clientErrMsgId,

                        getErrorString(errMsgId, vendorCode));
@@ -953,7 +952,6 @@ public class FingerprintManager { 
                final AuthenticationResult result =

                        new AuthenticationResult(mCryptoObject, fp, userId);

                mAuthenticationCallback.onAuthenticationSucceeded(result);

                mAuthenticationCallback = null;

            }

        }