Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e2d6f5c authored by Hawkwood's avatar Hawkwood
Browse files

Remove PredrawCallback when local ValueAnimator is complete 

Instead of removing the PredrawCallback when the transition at large
has ended, we additionally remove it when the local ValueAnimator is
ended. This may help in certain situations where onTransitionEnd
isn't being fired as expected. This fix is safe, but I'm uncertain
that it'll solve the leak for all edge cases.

Bug: 414596090
Flag: NONE Bugfix
Test: Manually checked clock switch animation in several scenarios
Change-Id: I97fa223f21a677a931eb676522fff0ea751cc41c
parent 65d07391

packages/SystemUI/src/com/android/systemui/keyguard/ui/view/layout/sections/transitions/ClockSizeTransition.kt

+4 −0
Original line number Diff line number Diff line
@@ -257,6 +257,10 @@ class ClockSizeTransition( 
                        override fun onAnimationEnd(anim: Animator) {

                            assignAnimValues("end", 1f, to.visibility, log = true)

                            if (sendToBack) to.view.translationZ = 0f



                            // This removal is effectively redundant with the one in onTransitionEnd

                            // but prevents the predraw listener from leaking the entire view tree.

                            to.view.viewTreeObserver.removeOnPreDrawListener(predrawCallback)

                        }

                    }