media: hook up MediaCodec.setSurface (5e02ba97) · Commits · e / os / android_frameworks_base

media/java/android/media/MediaCodec.java

+3 −3

Original line number	Diff line number	Diff line
		@@ -664,11 +664,11 @@ final public class MediaCodec {
		if (!mHasSurface) {
		throw new IllegalStateException("codec was not configured for an output surface");
		}

		// TODO implement this
		throw new IllegalArgumentException("codec does not support this surface");
		native_setSurface(surface);
		}

		private native void native_setSurface(@NonNull Surface surface);

		/**
		* Create a persistent input surface that can be used with codecs that normally have an input
		* surface, such as video encoders. A persistent input can be reused by subsequent

media/jni/android_media_MediaCodec.cpp

+50 −0

Original line number	Diff line number	Diff line
		@@ -245,6 +245,19 @@ status_t JMediaCodec::configure(
		return mCodec->configure(format, mSurfaceTextureClient, crypto, flags);
		}

		status_t JMediaCodec::setSurface(
		const sp<IGraphicBufferProducer> &bufferProducer) {
		sp<Surface> client;
		if (bufferProducer != NULL) {
		client = new Surface(bufferProducer, true /* controlledByApp */);
		}
		status_t err = mCodec->setSurface(client);
		if (err == OK) {
		mSurfaceTextureClient = client;
		}
		return err;
		}

		status_t JMediaCodec::createInputSurface(
		sp<IGraphicBufferProducer>* bufferProducer) {
		return mCodec->createInputSurface(bufferProducer);
		@@ -797,6 +810,10 @@ static jint throwExceptionAsNecessary(
		jniThrowException(env, "java/lang/IllegalStateException", msg);
		return 0;

		case BAD_VALUE:
		jniThrowException(env, "java/lang/IllegalArgumentException", msg);
		return 0;

		default:
		if (isCryptoError(err)) {
		throwCryptoException(env, err, msg);
		@@ -869,6 +886,35 @@ static void android_media_MediaCodec_native_configure(
		throwExceptionAsNecessary(env, err);
		}

		static void android_media_MediaCodec_native_setSurface(
		JNIEnv *env,
		jobject thiz,
		jobject jsurface) {
		sp<JMediaCodec> codec = getMediaCodec(env, thiz);

		if (codec == NULL) {
		throwExceptionAsNecessary(env, INVALID_OPERATION);
		return;
		}

		sp<IGraphicBufferProducer> bufferProducer;
		if (jsurface != NULL) {
		sp<Surface> surface(android_view_Surface_getSurface(env, jsurface));
		if (surface != NULL) {
		bufferProducer = surface->getIGraphicBufferProducer();
		} else {
		jniThrowException(
		env,
		"java/lang/IllegalArgumentException",
		"The surface has been released");
		return;
		}
		}

		status_t err = codec->setSurface(bufferProducer);
		throwExceptionAsNecessary(env, err);
		}

		static jobject android_media_MediaCodec_createInputSurface(JNIEnv* env,
		jobject thiz) {
		ALOGV("android_media_MediaCodec_createInputSurface");
		@@ -1530,6 +1576,10 @@ static JNINativeMethod gMethods[] = {
		"Landroid/media/MediaCrypto;I)V",
		(void *)android_media_MediaCodec_native_configure },

		{ "native_setSurface",
		"(Landroid/view/Surface;)V",
		(void *)android_media_MediaCodec_native_setSurface },

		{ "createInputSurface", "()Landroid/view/Surface;",
		(void *)android_media_MediaCodec_createInputSurface },

media/jni/android_media_MediaCodec.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -53,6 +53,9 @@ struct JMediaCodec : public AHandler {
		const sp<ICrypto> &crypto,
		int flags);

		status_t setSurface(
		const sp<IGraphicBufferProducer> &surface);

		status_t createInputSurface(sp<IGraphicBufferProducer>* bufferProducer);

		status_t start();