Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d85d8f3 authored by tim peng's avatar tim peng Committed by Android (Google) Code Review
Browse files

Merge "Output Switcher shows "+" button next to some non-expandable device" into sc-dev

parents 635e511b 054ba188

packages/SystemUI/src/com/android/systemui/media/dialog/MediaOutputAdapter.java

+12 −6
Original line number Diff line number Diff line
@@ -128,7 +128,8 @@ public class MediaOutputAdapter extends MediaOutputBaseAdapter { 
            }

            mBottomDivider.setVisibility(View.GONE);

            mCheckBox.setVisibility(View.GONE);

            if (currentlyConnected && mController.isActiveRemoteDevice(device)) {

            if (currentlyConnected && mController.isActiveRemoteDevice(device)

                    && mController.getSelectableMediaDevice().size() > 0) {

                // Init active device layout

                mDivider.setVisibility(View.VISIBLE);

                mDivider.setTransitionAlpha(1);
@@ -186,11 +187,16 @@ public class MediaOutputAdapter extends MediaOutputBaseAdapter { 
                mConnectedItem = mContainerLayout;

                mBottomDivider.setVisibility(View.GONE);

                mCheckBox.setVisibility(View.GONE);

                if (mController.getSelectableMediaDevice().size() > 0) {

                    mDivider.setVisibility(View.VISIBLE);

                    mDivider.setTransitionAlpha(1);

                    mAddIcon.setVisibility(View.VISIBLE);

                    mAddIcon.setTransitionAlpha(1);

                    mAddIcon.setOnClickListener(v -> onEndItemClick());

                } else {

                    mDivider.setVisibility(View.GONE);

                    mAddIcon.setVisibility(View.GONE);

                }

                mTitleIcon.setImageDrawable(getSpeakerDrawable());

                final CharSequence sessionName = mController.getSessionName();

                final CharSequence title = TextUtils.isEmpty(sessionName)

packages/SystemUI/tests/src/com/android/systemui/media/dialog/MediaOutputAdapterTest.java

+17 −9
Original line number Diff line number Diff line
@@ -135,8 +135,6 @@ public class MediaOutputAdapterTest extends SysuiTestCase { 
        mMediaOutputAdapter.onBindViewHolder(mViewHolder, 0);



        assertThat(mViewHolder.mSeekBar.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mDivider.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mAddIcon.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mTwoLineLayout.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mTitleText.getVisibility()).isEqualTo(View.GONE);

        assertThat(mViewHolder.mProgressBar.getVisibility()).isEqualTo(View.GONE);
@@ -154,8 +152,6 @@ public class MediaOutputAdapterTest extends SysuiTestCase { 
        mMediaOutputAdapter.onBindViewHolder(mViewHolder, 0);



        assertThat(mViewHolder.mSeekBar.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mDivider.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mAddIcon.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mTwoLineLayout.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mTitleText.getVisibility()).isEqualTo(View.GONE);

        assertThat(mViewHolder.mProgressBar.getVisibility()).isEqualTo(View.GONE);
@@ -176,9 +172,25 @@ public class MediaOutputAdapterTest extends SysuiTestCase { 
        assertThat(mViewHolder.mBottomDivider.getVisibility()).isEqualTo(View.GONE);

        assertThat(mViewHolder.mTwoLineTitleText.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mSeekBar.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mTwoLineTitleText.getText()).isEqualTo(TEST_DEVICE_NAME_1);

    }



    @Test

    public void onBindViewHolder_bindConnectedDevice_withSelectableDevice_showAddIcon() {

        when(mMediaOutputController.getSelectableMediaDevice()).thenReturn(mMediaDevices);

        mMediaOutputAdapter.onBindViewHolder(mViewHolder, 0);



        assertThat(mViewHolder.mDivider.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mAddIcon.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mTwoLineTitleText.getText()).isEqualTo(TEST_DEVICE_NAME_1);

    }



    @Test

    public void onBindViewHolder_bindConnectedDevice_withoutSelectableDevice_hideAddIcon() {

        when(mMediaOutputController.getSelectableMediaDevice()).thenReturn(new ArrayList<>());

        mMediaOutputAdapter.onBindViewHolder(mViewHolder, 0);



        assertThat(mViewHolder.mDivider.getVisibility()).isEqualTo(View.GONE);

        assertThat(mViewHolder.mAddIcon.getVisibility()).isEqualTo(View.GONE);

    }



    @Test
@@ -245,8 +257,6 @@ public class MediaOutputAdapterTest extends SysuiTestCase { 
        assertThat(mViewHolder.mCheckBox.getVisibility()).isEqualTo(View.GONE);

        assertThat(mViewHolder.mBottomDivider.getVisibility()).isEqualTo(View.GONE);

        assertThat(mViewHolder.mProgressBar.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mDivider.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mAddIcon.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mTwoLineTitleText.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mTwoLineTitleText.getText()).isEqualTo(TEST_DEVICE_NAME_1);

    }
@@ -263,8 +273,6 @@ public class MediaOutputAdapterTest extends SysuiTestCase { 
        assertThat(mViewHolder.mCheckBox.getVisibility()).isEqualTo(View.GONE);

        assertThat(mViewHolder.mBottomDivider.getVisibility()).isEqualTo(View.GONE);

        assertThat(mViewHolder.mTitleText.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mDivider.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mAddIcon.getVisibility()).isEqualTo(View.VISIBLE);

        assertThat(mViewHolder.mTitleText.getText()).isEqualTo(TEST_DEVICE_NAME_1);

    }