Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d4c35d1 authored by Adam Powell's avatar Adam Powell
Browse files

Remove the View#initializeScrollbars API 

This was never a safe API for apps to call since the TypedArray
parameter must have been obtained by filtering on
android.R.styleable.View, which is not public. Any behavior in the
wild has therefore been undefined.

Change-Id: Id19f571c92748ef2a8c036072fd83a417527f779
parent 2322ae82

api/current.txt

+0 −1
Original line number Diff line number Diff line
@@ -30569,7 +30569,6 @@ package android.view { 
    method public boolean hasWindowFocus();

    method public static android.view.View inflate(android.content.Context, int, android.view.ViewGroup);

    method protected void initializeFadingEdge(android.content.res.TypedArray);

    method protected void initializeScrollbars(android.content.res.TypedArray);

    method public void invalidate(android.graphics.Rect);

    method public void invalidate(int, int, int, int);

    method public void invalidate();

api/removed.txt

+8 −0
Original line number Diff line number Diff line 
package android.view {



  public class View implements android.view.accessibility.AccessibilityEventSource android.graphics.drawable.Drawable.Callback android.view.KeyEvent.Callback {

    method protected void initializeScrollbars(android.content.res.TypedArray);

  }



}

core/java/android/view/View.java

+3 −0
Original line number Diff line number Diff line
@@ -4307,6 +4307,9 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 
     * </p>

     *

     * @param a the styled attributes set to initialize the scrollbars from

     *

     * @removed Apps were never able to call this safely since the TypedArray parameter

     * must have been obtained by filtering on android.R.styleable.View, which is not public.

     */

    protected void initializeScrollbars(TypedArray a) {

        initScrollCache();