Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5cdc8a48 authored by Tianjie's avatar Tianjie
Browse files

Catch security exceptions in RoR APIs 

The security exceptions in RoR API caused the OTA reboot to stuck.
Since the error isn't related to the input of clients and clients
already have a fallback path; catch and and rethrow the security
exception as an IOException.

Bug: 183475757
Test: OTA falls back to normal reboot upon security exceptions
Change-Id: I359f2f85bd1f0f8734011aa2db24dd7abe0aaa03
parent d7858116

core/java/android/os/RecoverySystem.java

+10 −11
Original line number Diff line number Diff line
@@ -1361,8 +1361,8 @@ public class RecoverySystem { 
    private boolean requestLskf(String packageName, IntentSender sender) throws IOException {

        try {

            return mService.requestLskf(packageName, sender);

        } catch (RemoteException e) {

            throw new IOException("could request LSKF capture");

        } catch (RemoteException | SecurityException e) {

            throw new IOException("could not request LSKF capture", e);

        }

    }
@@ -1375,8 +1375,8 @@ public class RecoverySystem { 
    private boolean clearLskf(String packageName) throws IOException {

        try {

            return mService.clearLskf(packageName);

        } catch (RemoteException e) {

            throw new IOException("could not clear LSKF");

        } catch (RemoteException | SecurityException e) {

            throw new IOException("could not clear LSKF", e);

        }

    }
@@ -1390,8 +1390,8 @@ public class RecoverySystem { 
    private boolean isLskfCaptured(String packageName) throws IOException {

        try {

            return mService.isLskfCaptured(packageName);

        } catch (RemoteException e) {

            throw new IOException("could not get LSKF capture state");

        } catch (RemoteException | SecurityException e) {

            throw new IOException("could not get LSKF capture state", e);

        }

    }
@@ -1403,12 +1403,11 @@ public class RecoverySystem { 
            throws IOException {

        try {

            return mService.rebootWithLskf(packageName, reason, slotSwitch);

        } catch (RemoteException e) {

            throw new IOException("could not reboot for update");

        } catch (RemoteException | SecurityException e) {

            throw new IOException("could not reboot for update", e);

        }

    }





    /**

     * Calls the recovery system service to reboot and apply update. This is the legacy API and

     * expects a slot switch for A/B devices.
@@ -1418,8 +1417,8 @@ public class RecoverySystem { 
            throws IOException {

        try {

            return mService.rebootWithLskfAssumeSlotSwitch(packageName, reason);

        } catch (RemoteException e) {

            throw new IOException("could not reboot for update");

        } catch (RemoteException | RuntimeException e) {

            throw new IOException("could not reboot for update", e);

        }

    }