Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ccbeec5 authored by Adam He's avatar Adam He
Browse files

Add lifecycle states to Session to help add clarity and ease of 

maintenance to Sessions.

* mSessionState is the unique lifecycle State of the current Session.

* mSessionInfo contains metadata and other state identifying booleans
for the current Session.

Bug: 171350451
Bug: 162357598
Test: atest CtsAutoFillServiceTestCases
Change-Id: Id8cead9e5299b3f4e24c035706e04fa46555fc9b
parent 7d79aae5

services/autofill/java/com/android/server/autofill/AutofillManagerServiceImpl.java

+2 −2
Original line number Diff line number Diff line
@@ -1138,7 +1138,7 @@ final class AutofillManagerServiceImpl 
        final int sessionCount = mSessions.size();

        for (int i = sessionCount - 1; i >= 0; i--) {

            final Session session = mSessions.valueAt(i);

            if (session.isSavingLocked()) {

            if (session.isSaveUiShowingLocked()) {

                if (sDebug) Slog.d(TAG, "destroyFinishedSessionsLocked(): " + session.id);

                session.forceRemoveFromServiceLocked();

            } else {
@@ -1660,7 +1660,7 @@ final class AutofillManagerServiceImpl 


                    if (sessionToRemove != null && sessionsToRemove.valueAt(i)

                            == sessionToRemove.getActivityTokenLocked()) {

                        if (sessionToRemove.isSavingLocked()) {

                        if (sessionToRemove.isSaveUiShowingLocked()) {

                            if (sVerbose) {

                                Slog.v(TAG, "Session " + sessionToRemove.id + " is saving");

                            }

services/autofill/java/com/android/server/autofill/Session.java

+138 −71

File changed.

Preview size limit exceeded, changes collapsed.