Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c2f8399 authored by Adam Powell's avatar Adam Powell
Browse files

Un-hide string set persistence methods in Preference 

6 years is enough time for API approval.

Bug 27324328

Change-Id: I5d5af0fc291250cd9ea5b50cd5031378475eacec
parent a572e4a8

api/current.txt

+2 −0
Original line number Diff line number Diff line
@@ -29525,6 +29525,7 @@ package android.preference { 
    method protected int getPersistedInt(int);

    method protected long getPersistedLong(long);

    method protected java.lang.String getPersistedString(java.lang.String);

    method public java.util.Set<java.lang.String> getPersistedStringSet(java.util.Set<java.lang.String>);

    method public android.preference.PreferenceManager getPreferenceManager();

    method public android.content.SharedPreferences getSharedPreferences();

    method public boolean getShouldDisableView();
@@ -29559,6 +29560,7 @@ package android.preference { 
    method protected boolean persistInt(int);

    method protected boolean persistLong(long);

    method protected boolean persistString(java.lang.String);

    method public boolean persistStringSet(java.util.Set<java.lang.String>);

    method public void restoreHierarchyState(android.os.Bundle);

    method public void saveHierarchyState(android.os.Bundle);

    method public void setDefaultValue(java.lang.Object);

api/system-current.txt

+2 −0
Original line number Diff line number Diff line
@@ -31895,6 +31895,7 @@ package android.preference { 
    method protected int getPersistedInt(int);

    method protected long getPersistedLong(long);

    method protected java.lang.String getPersistedString(java.lang.String);

    method public java.util.Set<java.lang.String> getPersistedStringSet(java.util.Set<java.lang.String>);

    method public android.preference.PreferenceManager getPreferenceManager();

    method public android.content.SharedPreferences getSharedPreferences();

    method public boolean getShouldDisableView();
@@ -31929,6 +31930,7 @@ package android.preference { 
    method protected boolean persistInt(int);

    method protected boolean persistLong(long);

    method protected boolean persistString(java.lang.String);

    method public boolean persistStringSet(java.util.Set<java.lang.String>);

    method public void restoreHierarchyState(android.os.Bundle);

    method public void saveHierarchyState(android.os.Bundle);

    method public void setDefaultValue(java.lang.Object);

api/test-current.txt

+2 −0
Original line number Diff line number Diff line
@@ -29535,6 +29535,7 @@ package android.preference { 
    method protected int getPersistedInt(int);

    method protected long getPersistedLong(long);

    method protected java.lang.String getPersistedString(java.lang.String);

    method public java.util.Set<java.lang.String> getPersistedStringSet(java.util.Set<java.lang.String>);

    method public android.preference.PreferenceManager getPreferenceManager();

    method public android.content.SharedPreferences getSharedPreferences();

    method public boolean getShouldDisableView();
@@ -29569,6 +29570,7 @@ package android.preference { 
    method protected boolean persistInt(int);

    method protected boolean persistLong(long);

    method protected boolean persistString(java.lang.String);

    method public boolean persistStringSet(java.util.Set<java.lang.String>);

    method public void restoreHierarchyState(android.os.Bundle);

    method public void saveHierarchyState(android.os.Bundle);

    method public void setDefaultValue(java.lang.Object);

core/java/android/preference/Preference.java

+3 −7
Original line number Diff line number Diff line
@@ -1494,11 +1494,9 @@ public class Preference implements Comparable<Preference> { 
     * @return True if the Preference is persistent. (This is not whether the

     *         value was persisted, since we may not necessarily commit if there

     *         will be a batch commit later.)

     * @see #getPersistedString(Set)

     * 

     * @hide Pending API approval

     * @see #getPersistedStringSet(Set)

     */

    protected boolean persistStringSet(Set<String> values) {

    public boolean persistStringSet(Set<String> values) {

        if (shouldPersist()) {

            // Shouldn't store null

            if (values.equals(getPersistedStringSet(null))) {
@@ -1527,10 +1525,8 @@ public class Preference implements Comparable<Preference> { 
     * @return The value from the SharedPreferences or the default return

     *         value.

     * @see #persistStringSet(Set)

     * 

     * @hide Pending API approval

     */

    protected Set<String> getPersistedStringSet(Set<String> defaultReturnValue) {

    public Set<String> getPersistedStringSet(Set<String> defaultReturnValue) {

        if (!shouldPersist()) {

            return defaultReturnValue;

        }