Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b88363e authored by Christopher Wiley's avatar Christopher Wiley
Browse files

Tighten up compiler flags for aidl 

Turn all warnings to errors, with special cases for places where
yacc forces us to be lenient.  Remove one variable with 0 references
elsewhere in the code.

These flags are confined to be clang only because the Windows SDK build
is using an older compiler that does not understand these flags.

Change-Id: I6407bd331c25b8845bde46e9a917bce1d6857bd8
parent 60dd5d59

tools/aidl/Android.mk

+11 −1
Original line number Diff line number Diff line
@@ -8,6 +8,17 @@ ifeq ($(TARGET_BUILD_APPS)$(filter true,$(TARGET_BUILD_PDK)),) 
LOCAL_PATH:= $(call my-dir)

include $(CLEAR_VARS)



LOCAL_CLANG_CFLAGS := -Wall -Werror

# Tragically, the code is riddled with unused parameters.

LOCAL_CLANG_CFLAGS += -Wno-unused-parameter

# yacc dumps a lot of code *just in case*.

LOCAL_CLANG_CFLAGS += -Wno-unused-function

LOCAL_CLANG_CFLAGS += -Wno-unneeded-internal-declaration

# yacc is a tool from a more civilized age.

LOCAL_CLANG_CFLAGS += -Wno-deprecated-register

# yacc also has a habit of using char* over const char*.

LOCAL_CLANG_CFLAGS += -Wno-writable-strings



LOCAL_SRC_FILES := \

    AST.cpp \

    Type.cpp \
@@ -22,7 +33,6 @@ LOCAL_SRC_FILES := \ 
    options.cpp \

    search_path.cpp \



LOCAL_CFLAGS := -g

LOCAL_MODULE := aidl

LOCAL_MODULE_HOST_OS := darwin linux windows

tools/aidl/aidl.cpp

+0 −5
Original line number Diff line number Diff line
@@ -165,11 +165,6 @@ import_import_parsed(buffer_type* statement) 
{

}



static ParserCallbacks g_importCallbacks = {

    &main_document_parsed,

    &import_import_parsed

};



// ==========================================================

static int

check_filename(const char* filename, const char* package, buffer_type* name)