Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b5f1c0a authored by Joanne Chung's avatar Joanne Chung
Browse files

Use the flag FLAG_MUTABLE when creating the PendingIntent 

Starting with S, any app targeting S+ will need to specify
explicitly either FLAG_MUTABLE or FLAG_IMMUTABLE when creating
PendingIntents.

This change helps mitigate against implicit PendingIntent reuse.
At present, all PendingIntents are mutable by default unless
FLAG_IMMUTABLE is explicitly set when creating them. This often
leads to developers accidentally making the PendingIntents mutable
and thus handing their receivers powers to fill in critical fields.

Because the autofill saveui retore mechanism will need to update it,
the PendingIntent should be mutable.

Bug: 170771150
Test: atest CtsAutoFillServiceTestCases
Test: Manual. Make sure the function works normal.
Test: Don't see PendingIntent error log.
Change-Id: I6e03a48968b98dec10e9c9dc05d1f3af42f8f0e5
parent dae90d76

services/autofill/java/com/android/server/autofill/ui/SaveUi.java

+3 −3
Original line number Diff line number Diff line
@@ -198,8 +198,8 @@ final class SaveUi { 
                }

                intent.putExtra(AutofillManager.EXTRA_RESTORE_CROSS_ACTIVITY, true);



                PendingIntent p = PendingIntent.getActivityAsUser(

                        this, /* requestCode= */ 0, intent, /* flags= */ 0, /* options= */ null,

                PendingIntent p = PendingIntent.getActivityAsUser(this, /* requestCode= */ 0,

                        intent, PendingIntent.FLAG_MUTABLE, /* options= */ null,

                        UserHandle.CURRENT);

                if (sDebug) {

                    Slog.d(TAG, "startActivity add save UI restored with intent=" + intent);