Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b0af123 authored by Jay Sullivan's avatar Jay Sullivan
Browse files

Log callingUid from setUidMode 

...because for non-systemuid-sourced binder calls, the
logged stack trace currently tells us basically nothing
except that someone called AppOpsService::setUidMode.

Change-Id: Ia107e8f70d9fb5c53a157b189050483eb45e8e70
Bug: 341219398
Test: presubmit
parent 4bbcccde

services/permission/java/com/android/server/permission/access/appop/AppOpService.kt

+4 −1
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.server.permission.access.appop 


import android.app.AppOpsManager

import android.companion.virtual.VirtualDeviceManager

import android.os.Binder

import android.os.Handler

import android.os.UserHandle

import android.permission.PermissionManager
@@ -250,7 +251,9 @@ class AppOpService(private val service: AccessCheckingService) : AppOpsCheckingS 
        ) {

            Slog.w(

                LOG_TAG,

                "Cannot set UID mode for runtime permission app op, uid = $uid," +

                "Cannot set UID mode for runtime permission app op, " +

                    " callingUid = ${Binder.getCallingUid()}, " +

                    " uid = $uid," +

                    " code = ${AppOpsManager.opToName(code)}," +

                    " mode = ${AppOpsManager.modeToName(mode)}",

                RuntimeException()