Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b002e03 authored by Julia Tuttle's avatar Julia Tuttle
Browse files

RemoteInputView: Add null check in WindowInsetsAnimation.Callback 

We're seeing a rare but consistent crash here, so add a null check and
log an error. Ideally we'll get a repro case and find a root cause, but
this will mitigate the crash for now.

Bug: 219371276
Test: none, since we have no repro case
Change-Id: Ia8152f854c8d4fb8a85e221ffa1c781c2923cf40
parent c4088528

packages/SystemUI/src/com/android/systemui/statusbar/policy/RemoteInputView.java

+6 −2
Original line number Diff line number Diff line
@@ -264,8 +264,12 @@ public class RemoteInputView extends LinearLayout implements View.OnClickListene 
                super.onEnd(animation);

                if (animation.getTypeMask() == WindowInsets.Type.ime()) {

                    mEntry.mRemoteEditImeAnimatingAway = false;

                    mEntry.mRemoteEditImeVisible =

                            mEditText.getRootWindowInsets().isVisible(WindowInsets.Type.ime());

                    WindowInsets editTextRootWindowInsets = mEditText.getRootWindowInsets();

                    if (editTextRootWindowInsets == null) {

                        Log.w(TAG, "onEnd called on detached view", new Exception());

                    }

                    mEntry.mRemoteEditImeVisible = editTextRootWindowInsets != null

                            && editTextRootWindowInsets.isVisible(WindowInsets.Type.ime());

                    if (!mEntry.mRemoteEditImeVisible && !mEditText.mShowImeOnInputConnection) {

                        mController.removeRemoteInput(mEntry, mToken);

                    }