Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5afa545e authored by mattsziklay's avatar mattsziklay
Browse files

Only use width/height in animateEndDragToDesktop. 

Removes the use of startAbsBounds position in animateEndDragToDesktop in
favor of using width/height instead. This fixes an animation issue where
right/bottom split tasks would have an additional, unintended offset due
to task position not being (0, 0).

Bug: 323378048
Test: Manual
Flag: EXEMPT, minor change
Change-Id: If212628d13e746b069c27f16b2ed5194f4d57111
parent 58f45d9f

libs/WindowManager/Shell/src/com/android/wm/shell/desktopmode/DragToDesktopTransitionHandler.kt

+17 −7
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ import android.os.IBinder 
import android.os.SystemClock

import android.os.SystemProperties

import android.os.UserHandle

import android.util.Size

import android.view.Choreographer

import android.view.SurfaceControl

import android.view.SurfaceControl.Transaction
@@ -1397,7 +1398,11 @@ constructor( 
            state.draggedTaskChange ?: error("Expected non-null change of dragged task")

        val draggedTaskLeash = draggedTaskChange.leash

        val freeformTaskChanges = state.freeformTaskChanges

        val startBounds = draggedTaskChange.startAbsBounds

        val startSize =

            Size(

                draggedTaskChange.startAbsBounds.width(),

                draggedTaskChange.startAbsBounds.height(),

            )

        val endBounds = draggedTaskChange.endAbsBounds

        val currentVelocity = state.dragAnimator.computeCurrentVelocity()
@@ -1408,13 +1413,18 @@ constructor( 
        // end value, animate scale to 1.

        val startScale = state.dragAnimator.scale

        val startPosition = state.dragAnimator.position

        val startBoundsWithOffset =

            Rect(startBounds).apply { offset(startPosition.x.toInt(), startPosition.y.toInt()) }

        val startBounds =

            Rect(

                startPosition.x.toInt(),

                startPosition.y.toInt(),

                startPosition.x.toInt() + startSize.width,

                startPosition.x.toInt() + startSize.height,

            )



        logV(

            "animateEndDragToDesktop: startBounds=$startBounds, endBounds=$endBounds, " +

            "animateEndDragToDesktop: startSize=$startSize, endBounds=$endBounds, " +

                "startScale=$startScale, startPosition=$startPosition, " +

                "startBoundsWithOffset=$startBoundsWithOffset"

                "startBounds=$startBounds"

        )



        dragToDesktopStateListener?.onCommitToDesktopAnimationStart()
@@ -1424,11 +1434,11 @@ constructor( 
        onTaskResizeAnimationListener.onAnimationStart(

            state.draggedTaskId,

            startTransaction,

            startBoundsWithOffset,

            startBounds,

        )



        val tx: SurfaceControl.Transaction = transactionSupplier.get()

        PhysicsAnimator.getInstance(startBoundsWithOffset)

        PhysicsAnimator.getInstance(startBounds)

            .spring(

                FloatProperties.RECT_X,

                endBounds.left.toFloat(),