Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ada3c56 authored by John Reck's avatar John Reck Committed by Richard Uhler
Browse files

Revert "Reapply "SharedMemory: mark fdsan ownership"" 

This reverts commit 2e2685c3.

Reason for revert: The reapplication reintroduces a memory leak
Bug: 393198065
Test: atest SharedMemoryFileDescriptorTest

Change-Id: I5d410f05b061a41e089fa652e5565224a3488baf
parent 8ce3a826

core/java/android/os/SharedMemory.java

+9 −9
Original line number Diff line number Diff line
@@ -25,8 +25,6 @@ import android.system.OsConstants; 


import dalvik.system.VMRuntime;



import libcore.io.IoUtils;



import java.io.Closeable;

import java.io.FileDescriptor;

import java.io.IOException;
@@ -65,7 +63,7 @@ public final class SharedMemory implements Parcelable, Closeable { 


        mMemoryRegistration = new MemoryRegistration(mSize);

        mCleaner = Cleaner.create(mFileDescriptor,

                new Closer(mFileDescriptor, mMemoryRegistration));

                new Closer(mFileDescriptor.getInt$(), mMemoryRegistration));

    }



    /**
@@ -278,6 +276,7 @@ public final class SharedMemory implements Parcelable, Closeable { 
     */

    @Override

    public void close() {

        mFileDescriptor.setInt$(-1);

        if (mCleaner != null) {

            mCleaner.clean();

            mCleaner = null;
@@ -327,20 +326,21 @@ public final class SharedMemory implements Parcelable, Closeable { 
     * Cleaner that closes the FD

     */

    private static final class Closer implements Runnable {

        private FileDescriptor mFd;

        private int mFd;

        private MemoryRegistration mMemoryReference;



        private Closer(FileDescriptor fd, MemoryRegistration memoryReference) {

        private Closer(int fd, MemoryRegistration memoryReference) {

            mFd = fd;

            IoUtils.setFdOwner(mFd, this);

            mMemoryReference = memoryReference;

        }



        @Override

        public void run() {

            IoUtils.closeQuietly(mFd);

            mFd = null;



            try {

                FileDescriptor fd = new FileDescriptor();

                fd.setInt$(mFd);

                Os.close(fd);

            } catch (ErrnoException e) { /* swallow error */ }

            mMemoryReference.release();

            mMemoryReference = null;

        }