Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ad83ba5 authored by Ryan Mitchell's avatar Ryan Mitchell Committed by android-build-merger
Browse files

Merge "Set idmap2 binary uid and gid after forking" into qt-dev am: ebad9125 

am: e9acb9c5

Change-Id: I554b5b5a0ba53233ed94547898f75655fe97c3c3
parents d0a6dd49 e9acb9c5

libs/androidfw/PosixUtils.cpp

+13 −0
Original line number Diff line number Diff line
@@ -64,6 +64,9 @@ std::unique_ptr<ProcResult> ExecuteBinary(const std::vector<std::string>& argv) 
    return nullptr;

  }



  auto gid = getgid();

  auto uid = getuid();



  char const** argv0 = (char const**)malloc(sizeof(char*) * (argv.size() + 1));

  for (size_t i = 0; i < argv.size(); i++) {

    argv0[i] = argv[i].c_str();
@@ -75,6 +78,16 @@ std::unique_ptr<ProcResult> ExecuteBinary(const std::vector<std::string>& argv) 
      PLOG(ERROR) << "fork";

      return nullptr;

    case 0: // child

      if (setgid(gid) != 0) {

        PLOG(ERROR) << "setgid";

        exit(1);

      }



      if (setuid(uid) != 0) {

        PLOG(ERROR) << "setuid";

        exit(1);

      }



      close(stdout[0]);

      if (dup2(stdout[1], STDOUT_FILENO) == -1) {

        abort();