Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ad1ec1c authored by Michal Brzezinski's avatar Michal Brzezinski
Browse files

Showing wider header/status bar in shade on large screen 

Note: Because this change is already huge, I’ll do proper renaming of split shade header to large screen header in the follow-up CL.

- introducing new config flag: config_use_large_screen_shade_header and using it to determine which header should be visible
- Several adjustments to paddings and margins and how they are calculated on the fly, mostly from notification scrim and motion perspective. Recalculating scrim bounds relative to view bounds
- cleaning Utils.java which got very wide-reaching over time. Some things were not used at all and some could be moved. I extracted some functions to two separate utils classes (also open to better ideas): QSUtils and LargeScreenUtils. Not ideal but at least better than one big Util.

Fixes: 222472794
Test: expand shade on large screen device in portrait and see one row QS header taking full width of the screen
Test: NotificationPanelViewControllerTest + NotificationQSContainerControllerTest
Change-Id: I4988c09c367c721ea9a957df8d1442fc65a336de
parent fa5aefba

packages/SystemUI/res-keyguard/values-sw600dp-land/dimens.xml

+0 −1
Original line number Diff line number Diff line
@@ -22,7 +22,6 @@ 
    <!-- Overload default clock widget parameters -->

    <dimen name="widget_big_font_size">88dp</dimen>



    <dimen name="qs_header_system_icons_area_height">0dp</dimen>

    <dimen name="qs_panel_padding_top">@dimen/qqs_layout_margin_top</dimen>



</resources>
 
 No newline at end of file

packages/SystemUI/res/values-sw600dp-land/dimens.xml

+0 −1
Original line number Diff line number Diff line
@@ -36,7 +36,6 @@ 
    <item name="controls_task_view_width_percentage" translatable="false" format="float" type="dimen">0.45</item>

    <dimen name="controls_task_view_right_margin">8dp</dimen>



    <dimen name="split_shade_header_height">42dp</dimen>

    <dimen name="status_bar_header_height_keyguard">42dp</dimen>



    <!-- Distance that the full shade transition takes in order to complete by tapping on a button

packages/SystemUI/res/values-sw600dp/config.xml

+2 −0
Original line number Diff line number Diff line
@@ -38,4 +38,6 @@ 
    <!-- Determines whether to allow the nav bar handle to be forced to be opaque. -->

    <bool name="allow_force_nav_bar_handle_opaque">false</bool>



    <bool name="config_use_large_screen_shade_header">true</bool>



</resources>

packages/SystemUI/res/values-sw600dp/dimens.xml

+2 −0
Original line number Diff line number Diff line
@@ -67,4 +67,6 @@ 


    <!-- The width of large/content heavy dialogs (e.g. Internet, Media output, etc) -->

    <dimen name="large_dialog_width">472dp</dimen>



    <dimen name="split_shade_header_height">42dp</dimen>

</resources>

packages/SystemUI/res/values-sw720dp-land/dimens.xml

+0 −1
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ 


    <dimen name="keyguard_split_shade_top_margin">72dp</dimen>



    <dimen name="split_shade_header_height">56dp</dimen>

    <dimen name="status_bar_header_height_keyguard">56dp</dimen>



    <dimen name="qs_media_session_height_expanded">184dp</dimen>